patchmldonkey, a multi-networks file-sharing client - Patches: patch #4156, tray icon for x11

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4156: tray icon for x11

Submitter:  su_blanc <su_blanc>
Submitted:  Sat 09 Jul 2005 09:17:24 AM UTC
   
 
Category:  Improved interfaces Priority:  3 - Low
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Sun 10 Jul 2005 10:48:19 PM UTC, comment #8: 

"If you close the current console window of MLDonkey the process
is terminated without sending a signal to the process (SIGINT)...."

just to use mkwinapp.ml from http://ocaml-win32.sourceforge.net/

in windows you have 2 types of binaries called 'console subsystem' and 'window subsystem'. Ocaml build applications that use by default the 'console subsystem' i.e. open a console while the app is executed.
If you convert the binary to the 'window subsystem' (only possible for app compiled with native code) there is no more console but the app is still running. in our case mlgui.exe will be like a normal GUI without console in addition to the frontend interface and mlnet.exe will run in the background transparently (appears only in the tasks manager). we can also release the bundle version that will appear like any other windows app including the tray icon...

su_blanc <su_blanc>
Group Member
Sun 10 Jul 2005 04:09:16 PM UTC, comment #7: 

"so i will modify your patch #4155 for the win32 version if you agree."

No problem, discussion about this takes place here:
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&p=19824#19824

spiralvoice <spiralvoice>
Group administrator
Sun 10 Jul 2005 01:32:34 PM UTC, comment #6: 

x11_trayicon.patch applied 2005/07/10

spiralvoice <spiralvoice>
Group administrator
Sun 10 Jul 2005 12:08:25 PM UTC, comment #5: 

"- include an app to convert the .exe from console subsystem to windows subsystem during building (more windowish...). "
If you close the current console window of MLDonkey the process
is terminated without sending a signal to the process (SIGINT).
Therefore the core can not gracefully end itself, I know there are
ways in Ocaml to achieve this, are you planing something like this?

spiralvoice <spiralvoice>
Group administrator
Sun 10 Jul 2005 11:50:16 AM UTC, comment #4: 

"- enable by default the logs (because no more console window) "
patch #4126 already does this

spiralvoice <spiralvoice>
Group administrator
Sat 09 Jul 2005 11:53:34 PM UTC, comment #3: 

yes, no problem to release the gtk-2.0 gui.
i will submit soon (max next weekend) a complete patch for the win32 version that will include the following improvements:

- new nsi installer to build independant releases for mlnet.exe, mlgui.exe and mlnet+gui.exe
- different rc files for each binary.
- include an app to convert the .exe from console subsystem to windows subsystem during building (more windowish...).
- change the previewer to ease the use under windows (launch directly an .exe like vlc.exe ...)
- enable by default the logs (because no more console window)
- bug fix in options.ml4
- and other comestic changes ...

i would like also to change the directories for the windows version like this (generally from C:\Program Files\):

mlDonkey [ top directory ]
  bin [ mlnet.exe, mlgui.exe, mlnet+gui.exe and relative dlls ]
  config [ all config files of mlnet.exe ]
    old_config
  etc [ for gtk-2.0 aliases, engines and gtkrc ]
  incoming
    directories
    files
  interface
    config [ all config files of mlgui.exe and mlim.exe ]
      old_config
    themes [ gtk-2.0 themes like wimp ]
  lib [ for gtk-2.0 pango, immodules, loaders ... ]
  logs [ logs of mlnet.exe and mlchat.exe ]
  shared
  searches
  temp
  torrents
    downloads
    seeded
    tracked     
  webserver
    images [ graph for bandwidth ]
    html_themes

so i will modify your patch #4155 for the win32 version if you agree.

su_blanc <su_blanc>
Group Member
Sat 09 Jul 2005 11:22:16 PM UTC, comment #2: 

should fix bug #12391

su_blanc <su_blanc>
Group Member
Sat 09 Jul 2005 11:09:23 PM UTC, comment #1: 

Works well here on Gentoo x86 + KDE 3.4.1 + xorg-x11.
Will be included in one of the next CVS commits.
Is there any chance you can release a binary of the GTK2 GUI for Windows?

spiralvoice <spiralvoice>
Group administrator
Sat 09 Jul 2005 09:17:24 AM UTC, original submission:  

added eggtrayicon (from Anders Carlsson) bindings for x11.
closing the mlgui window will create an icon in the notification area.
You have now to do an explicit 'Quit' from the menu  or 'CTRL+W' to quit mlgui.

su_blanc <su_blanc>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9042:  x11_trayicon.patch added by su_blanc (30KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-17 spiralvoice Open/ClosedOpen Closed
2005-07-10 spiralvoice StatusNone Done
2005-07-09 su_blanc Attached File- Added x11_trayicon.patch, #4807

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code