patchmldonkey, a multi-networks file-sharing client - Patches: patch #4175, Adds Multiline File Information in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4175: Adds Multiline File Information in Web-Interface search results

Submitter:  Jochen Kokemüller <jkon>
Submitted:  Sat 16 Jul 2005 12:43:02 PM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Tue 19 Jul 2005 07:48:46 PM UTC, comment #11: 

Applied 4175_5.patch to CVS 2005/07/19.
If you have new patches please open a new patch for them here.

spiralvoice <spiralvoice>
Group administrator
Tue 19 Jul 2005 04:21:02 PM UTC, comment #10: 

This incremental patch adds some configuration abilities. It also adds timeouts to the toolboxes. Although it seems that at least the *_wait timeout causes some trouble.

Jochen Kokemüller <jkon>
Mon 18 Jul 2005 11:11:28 PM UTC, comment #9: 

@Jochen: Could you please take care of this bug?

spiralvoice <spiralvoice>
Group administrator
Mon 18 Jul 2005 12:17:42 AM UTC, comment #8: 

Confirmed. It fixes the problems that were introduced. So bug #13828 and bug #13829 most probably can be closed.

White_FrosT
Sun 17 Jul 2005 11:19:13 PM UTC, comment #7: 

Committed 4175_4.patch on 2005/07/18
Tested patch with Internet Explorer

spiralvoice <spiralvoice>
Group administrator
Sun 17 Jul 2005 06:20:37 PM UTC, comment #6: 

The new incremental patch is based upon current CVS.
It incoporates popups to the download page, and changes slightly the appearance.
Also it fixes a bug introduced by the new escaping of '.
(The Bandwith stats were affected, as there is the argument to the js function escaped by these '. Due to the escaping these signes where replaced by the HTML equiv. Maybe this also happend in other places.)

Jochen Kokemüller <jkon>
Sun 17 Jul 2005 04:07:16 PM UTC, comment #5: 

Committed 2005/07/17
Tested with Firefox 1.0.5, Konqueror 3.4.1 and Opera 8.01

spiralvoice <spiralvoice>
Group administrator
Sun 17 Jul 2005 12:18:47 AM UTC, comment #4: 

"I'm thinking about doing the same thing ... to the transfer page."
Yes, why not.

Did you test your code on several browsers?
Is it possible to have smaller letters in the popup?

spiralvoice <spiralvoice>
Group administrator
Sat 16 Jul 2005 11:02:37 PM UTC, comment #3: 

Yeah, I missed that for quite some while, so I did it myself! Isn't that the idea of open source!?

I'm thinking about doing the same thing, maybe without showing all the file names, to the transfer page. What do you think about that?
Although it doesn't seem to me that nessecary, it might be a nice to have.

Jochen Kokemüller <jkon>
Sat 16 Jul 2005 07:25:31 PM UTC, comment #2: 

Nice patch, btw

spiralvoice <spiralvoice>
Group administrator
Sat 16 Jul 2005 07:23:04 PM UTC, comment #1: 

"The Filename should be escaped properly."

http://www.dragonwinds.com/resources/html-codes.shtml

So ' should be converted to &#39;, in MLDonkey this is done in Http_server.html_escaped. Attached you will find 4175_3.patch
with the neccessary changes to be applied after 4175.patch.

spiralvoice <spiralvoice>
Group administrator
Sat 16 Jul 2005 12:43:02 PM UTC, original submission:  

This patch adds a Multiline javascript window to display detailed Information on search results. Within these there are uncut filenames.

Known Limitations:
The Filename should be escaped properly. If in the filename occurs a ' this results in a javascript error. I'm not into ocalm to be able to fix this.

The javascript is added to the "include" files:
distrib/html_themes/ease/i.js
src/daemon/common/commonMessages.ml
and not to:
distrib/html_themes/old/i.js
there is no real reason to this. Only that i don't understand there function.

I'm sorry but I made the changes to Version 2.5.30-1. I hope it is not too much work to port it to the current development version.

Jochen Kokemüller <jkon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9124:  4175_5.patch added by jkon (11KiB - application/octet-stream)
file #9092:  4175_4.patch added by jkon (10KiB - application/octet-stream)
file #9086:  4175_3.patch added by spiralvoice (2KiB - application/octet-stream)
file #9085:  4175_2.patch added by spiralvoice (10KiB - application/octet-stream - patch for current CVS)
file #9083:  patch added by jkon (8KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 7 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-19 jkon Attached File- Added 4175_5.patch, #4856
2005-07-17 jkon Attached File- Added 4175_4.patch, #4850
2005-07-17 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-07-16 spiralvoice Attached File- Added 4175_3.patch, #4841
2005-07-16 spiralvoice Attached File- Added 4175_2.patch, #4840
2005-07-16 jkon Attached File- Added patch, #4838

Back to the top

Powered by Savane 3.13-3230.
Corresponding source code