Concurrent Versions System - Patches: patch #4441, Add importinfo trigger, or cause...
You are not allowed to post comments on this tracker with your current authentication level.
patch #4441: Add importinfo trigger, or cause import to run commitinfo/loginfo combination as does commit.
Submitter: | Derek Robert Price <dprice> | ||
Submitted: | Mon 19 Sep 2005 06:09:13 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Fixed Release: | None | Fixed Feature Release: | None |
Mon 19 Sep 2005 06:26:22 PM UTC, comment #1: |
Derek Robert Price <dprice>![]() |
Mon 19 Sep 2005 06:09:13 PM UTC, original submission:
Was https://ccvs.cvshome.org/issues/show_bug.cgi?id=157:
We have a big problem with people accidentally
What I've done locally is to modify the import
I'd like to submit this patch for inclusion in
------- Additional comments from Joshua Davies Thu Feb 19 10:06:17 -0700 2004 -------
Created an attachment (id=67)
------- Additional comments from Joshua Davies Thu Feb 19 10:07:28 -0700 2004 -------
Sorry it took so long to include this patch; I ran into some
------- Additional comments from Derek Price Mon Mar 15 16:44:58 -0700 2004 -------
I looked over this patch and have several comments:
1. It needs src/sanity.sh test cases and documentation in
2. I think the comparison of the current user name to the readers,
3. The default comment in the importallowed file created by
4. How about renaming the file "importers" for consistency with the
5. The "not authorized to use this command" error message needs at
I am also going to send a message off to -email is unavailable- in hopes of
------- Additional comments from Derek Price Mon Mar 15 16:45:40 -0700 2004 -------
Incidentally, thanks for the patch submission!
------- Additional comments from Derek Price Mon Mar 15 16:48:25 -0700 2004 -------
General questions this patch raises for me:
1. This makes me itch for a more general permissions scheme, but
------- Additional comments from Derek Price Mon Mar 15 16:52:33 -0700 2004 -------
Adding myself to the CC list.
------- Additional comments from Derek Price Mon Mar 15 18:01:47 -0700 2004 -------
Mark D. Baushke <mdb@cvshome.org> writes:
I would rather see a CVSROOT/importinfo file with script that get run to
Such a script could use something like cvs_acls to determine that a
One of the biggest things I'd like to see such a script be able to
Having the special-purpose CVSROOT/importers seems less flexible to me.
For that matter, I think it might be useful to have trigger scripts for
-- Mark
------- Additional comments from Derek Price Mon Mar 15 18:05:05 -0700 2004 -------
This is exactly the sort of thing I was fishing for. An importinfo
------- Additional comments from Ingolf Steinbach Tue Mar 16 05:16:02 -0700 2004 -------
Derek wrote on 2004-03-15:
Kind regards
------- Additional comments from Derek Price Tue Mar 16 08:39:26 -0700 2004 -------
Larry Jones <lawrence.jones@ugsplm.com> writes:
run to
------- Additional comments from Derek Price Tue Mar 16 08:41:50 -0700 2004 -------
Extending commitinfo should be even easier to add with the new API. A
------- Additional comments from Derek Price Tue Mar 16 09:14:21 -0700 2004 -------
Mark D. Baushke Writes:
Extending the commitinfo would be acceptable to me provided that access
------- Additional comments from Derek Price Tue Mar 16 09:31:22 -0700 2004 -------
Good point again, Mark. It should be useful and easy enough to extend
As for the list of release tags (don't forget it is a list), this
ALL $CVSROOT/CVSROOT/myscript %r %p $T %{t} -- %{sV}
------- Additional comments from Mark D. Baushke Tue Mar 16 09:45:39 -0700 2004 -------
Derek Robert Price <derek@ximbiot.com> writes:
Would the commitinfo script be called once for the entire
It might also be useful for the 'cvs add' and 'cvs import'
------- Additional comments from Derek Price Tue Mar 16 10:17:51 -0700 2004 -------
And %T isn't being set yet. I was just suggesting it.
Usage: cvs import [-d] [-k subst] [-I ign] [-m msg] [-b branch]
I don't know how often people use that functionality, but as long as
------- Additional comments from Derek Price Tue Mar 16 14:05:56 -0700 2004 -------
Larry Jones writes:
necessary, or
------- Additional comments from Joshua Davies Thu Mar 18 10:14:25 -0700 2004 -------
Wow - I've sparked quite a debate, here. I'd be more than happy to
Minor comment from an FNG, though - if, as Mark Baushke suggests,
------- Additional comments from Derek Price Thu Mar 18 11:00:30 -0700 2004 -------
I wouldn't think a filename change is necessary, per se. Add of a
Neither would I consider the name change a big deal if you want to
------- Additional comments from Joshua Davies Sat Mar 27 09:40:57 -0700 2004 -------
Ok, I've made some progress on this - and dug much deeper into the CVS
Would it make sense to add another keyword, IMPORT, to be invoked on
module1 $CVSROOT/CVSROOT/sanity-check.sh %p %r %{s}
------- Additional comments from Derek Price Sat Mar 27 11:36:09 -0700 2004 -------
Do you have a good reason for wanting to differentiate the import from
If there is a good reason, what advantage does the IMPORT flag have
------- Additional comments from Joshua Davies Sun Mar 28 08:21:06 -0700 2004 -------
Well, remember that my original use-case was to restrict the
#!/bin/sh
if [ "$1" == "import" ]
Let me do this - I'm almost done with the change to make the import
------- Additional comments from Derek Price Sun Mar 28 09:47:15 -0700 2004 -------
Sounds good.
------- Additional comments from Derek Price Mon Jun 7 06:20:52 -0700 2004 -------
------- Additional comments from Joshua Davies Wed Jul 28 13:10:32 -0700 2004 -------
In case you're curious, I haven't given up on this... it's just a lot trickier
Adding the branch & version info is a bit trickier, though, and this seems to
|
Derek Robert Price <dprice>![]() |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2005-09-19 | dprice | Dependencies | - | ![]() |
task #4686 is dependent |
2005-09-19 | dprice | Attached File | - | ![]() |
Added importallow.diff, #5211 |
Carbon-Copy | - | ![]() |
Added -email is unavailable- |
Joshua, re your last question, something like %{sbvV} is fine, though I think I would prefer `t' to `b' to stay consitent with the %t operation in the taginfo hook.
Sorry for the long delay in my response. The old bug tracker didn't cc bug-cvs and this one does, so responses should be faster.
Thanks,