patchmldonkey, a multi-networks file-sharing client - Patches: patch #5136, FileTP: fixes and enhancements

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5136: FileTP: fixes and enhancements

Submitter:  z <zet>
Submitted:  Fri 26 May 2006 02:06:39 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Tue 30 May 2006 10:54:23 AM UTC, comment #6: 

Applied 2006/05/30

spiralvoice <spiralvoice>
Group administrator
Sun 28 May 2006 06:12:14 AM UTC, comment #5: 

Added support for user/pass (http://user:pass@site or ftp://user:pass@site). This also adds user/pass support to http_client.

Error codes from HTTP (ie: 404) and some from FTP are supported (530 sometimes signals a retry, sometimes a login failure so a regex was used (lftp)).

Downloads are paused when a hard error is received (and noted in the log).

z <zet>
Group Member
Sat 27 May 2006 12:58:18 PM UTC, comment #4: 

This patch doesn't change error code handling.  This can be done in another patch.  The download should be handled the same as before. (Connect will timeout I assume).

z <zet>
Group Member
Sat 27 May 2006 12:22:35 PM UTC, comment #3: 

Thx, it works now.
Another problem, is it possible to use error code 530 somehow?
I tried to download
ftp://ftp.berlios.de/pub/mldonkey/pango/Wiki_ZIP_DUMP.zip,
opened the directory listing in Firefox first, then MLDonkey
got this error:

00000170: 6f 77 2e 0d 0a 35 33 30  20 53 6f 72 72 79 2c 20  |ow...530.Sorry,.|
00000180: 79 6f 75 20 6d 61 79 20  6e 6f 74 20 63 6f 6e 6e  |you.may.not.conn|
00000190: 65 63 74 20 6d 6f 72 65  20 74 68 65 6e 20 32 20  |ect.more.then.2.|
000001a0: 74 69 6d 65 73 2e 0d 0a                           |times...        |

MLDonkey could retry to connect later again, currently the download is frozen.

spiralvoice <spiralvoice>
Group administrator
Fri 26 May 2006 11:39:59 PM UTC, comment #2: 

Updated patch, seems to work on that ftp now.
ftp.microsoft.com was a problem before the patch.

z <zet>
Group Member
Fri 26 May 2006 09:50:07 PM UTC, comment #1: 
  • downloading http works well, http server version is printed nicely
  • download ftp makes problems:

this URL
ftp://ftp2.de.freebsd.org/pub/FreeBSD/ISO-IMAGES-i386/6.1/6.1-RELEASE-i386-disc1.iso
can be downloaded with unpatched MLDonkey without problems,
with your patch a password is never sent on login.

With unpatched MLDonkey:

T 134.76.11.100:21 -> x.x.x.x:63906 [AP]
  331 Guest login ok, send your complete e-mail address as password...
T x.x.x.x:63886 -> 134.76.11.100:21 [AP]
  USER anonymous..PASS -mldonkey@..SYST..PWD..TYPE I..CWD /pub/FreeBSD/ISO-IMAGES-i386/6.1..SIZE 6.1-RELEASE-i386-disc1.iso..

and downloading begins.

With patched MLDonkey:

mldonkey:/ # ngrep -d ppp0 host 134.76.11.100
interface: ppp0 (x.x.x.x/255.255.255.255)
filter: ip and ( host 134.76.11.100 )
#######
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  220-====================================================================..
##
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  220-====================================================================..
##
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  220-Gesellschaft fuer wissenschaftliche Datenverarbeitung mbH Goettingen..220-====================================================================
  ..220-This is a Linux PC (Dell PE-2650, 2 CPUs P4/2800, 12 GB RAM)..220-running SuSE-Linux-8.2 with SuSE kernel 2.4.20-64GB-SMP...220-/pub is ext3
  , a 2 TB Partition within a Transtec T6100F16R1..220-IDE/FC Raid array with 15+1 SATA disks Hitachi 240 GB Raid5..220-..220-For questions and othe
  r contacts to the ftp-admin, mailto:emoenke@gwdg.de..220-All transfers are logged. The local time is Fri May 26 23:48:23 2006...220-..220-Limits:
  Domains gwdg.de, uni-goettingen.de, mpg.de:  200 sessions..220-        Other domains:      Mon - Fri 8:00 - 18:00: 1000 sessions..220-
                             other times: 2000 sessions..220-Your domain limit: 2000    active sessions: 418..220-..220-Login as "ftp" or "anonymous
  " and use your email address as password...220-..220 ftp.gwdg.de FTP server (Version wu-2.4.2-academ[BETA-18-em](1) Fri Apr 4 23:14:50 MEST 2003)
  ready...
##
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  220-Gesellschaft fuer wissenschaftliche Datenverarbeitung mbH Goettingen..220-====================================================================
  ..220-This is a Linux PC (Dell PE-2650, 2 CPUs P4/2800, 12 GB RAM)..220-running SuSE-Linux-8.2 with SuSE kernel 2.4.20-64GB-SMP...220-/pub is ext3
  , a 2 TB Partition within a Transtec T6100F16R1..220-IDE/FC Raid array with 15+1 SATA disks Hitachi 240 GB Raid5..220-..220-For questions and othe
  r contacts to the ftp-admin, mailto:emoenke@gwdg.de..220-All transfers are logged. The local time is Fri May 26 23:48:23 2006...220-..220-Limits:
  Domains gwdg.de, uni-goettingen.de, mpg.de:  200 sessions..220-        Other domains:      Mon - Fri 8:00 - 18:00: 1000 sessions..220-
                             other times: 2000 sessions..220-Your domain limit: 2000    active sessions: 418..220-..220-Login as "ftp" or "anonymous
  " and use your email address as password...220-..220 ftp.gwdg.de FTP server (Version wu-2.4.2-academ[BETA-18-em](1) Fri Apr 4 23:14:50 MEST 2003)
  ready...
#
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T x.x.x.x:64062 -> 134.76.11.100:21 [AP]
  USER anonymous..
####
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  331 Guest login ok, send your complete e-mail address as password...
##
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
##
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T x.x.x.x:64062 -> 134.76.11.100:21 [AP]
  USER anonymous..
##
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  331 Guest login ok, send your complete e-mail address as password...
##
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T x.x.x.x:64062 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
##
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
##
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
##
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T x.x.x.x:64062 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T 134.76.11.100:21 -> x.x.x.x:64062 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
#
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
#
T x.x.x.x:64061 -> 134.76.11.100:21 [AP]
  USER anonymous..
##
T 134.76.11.100:21 -> x.x.x.x:64061 [AP]
  331 Guest login ok, send your complete e-mail address as password...
##
T x.x.x.x:64062 -> 134.76.11.100:21 [AP]
  USER anonymous..
#

this goes on forever...

spiralvoice <spiralvoice>
Group administrator
Fri 26 May 2006 02:06:39 PM UTC, original submission:  
  • Add "FTP-chunk_size" option (in bytes) (0 = no chunks = download full file at once)

-- A chunk_size would be required if downloading from > 1 source

  • Add FTP downloads to bandwidth controller (for stats & speed limiter)
  • Support FTP sites that do not buffer input (MS FTP)


z <zet>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10067:  filetp-2.diff added by zet (48KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 7 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-05-30 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2006-05-28 zet Attached File- Added filetp-2.diff, #10067
2006-05-28 zet Attached File#10060 Removed
2006-05-26 zet Attached File- Added filetp.diff, #10060
2006-05-26 zet Attached File#10058 Removed
2006-05-26 zet Attached File- Added filetp.diff, #10058

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code