lwIP - A Lightweight TCP/IP stack - Patches: patch #5506, api_lib.c: netbuf_copy_partial()...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5506: api_lib.c: netbuf_copy_partial() use memcpy instead of byte copy
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Tue 31 Oct 2006 07:56:35 AM UTC | ||
Category: | None | Priority: | 3 - Low |
Status: | None | Privacy: | Public |
Assigned to: | jifl | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Tue 27 Feb 2007 07:23:41 AM UTC, comment #6: |
Simon Goldschmidt <goldsimon> |
Mon 26 Feb 2007 07:52:16 PM UTC, comment #5: Checked in. Simon, please try it out and let me know if you're not happy with it. |
Jonathan Larmour <jifl> |
Mon 26 Feb 2007 05:19:49 PM UTC, comment #4: I've made a few slight tweaks to the patch to simplify and slightly improve it a little. I can apply it when I get CVS write access working.
|
Jonathan Larmour <jifl> |
Mon 26 Feb 2007 04:40:18 PM UTC, comment #3: My only concern is that there may be some platforms that don't have a memcpy function, but as we use memcpy elsewhere in the core code this is a moot point.
|
Kieran Mansley <kieranm> |
Mon 26 Feb 2007 04:09:48 PM UTC, comment #2: I use this patch, and it seems to work fine for me (no problem, and I got a performance gain).
|
Frédéric Bernon <fbernon> |
Fri 01 Dec 2006 08:56:54 AM UTC, comment #1: Hi,
|
Frédéric Bernon <fbernon> |
Tue 31 Oct 2006 07:56:35 AM UTC, original submission:
(As you probably all know:) netbuf_copy_partial() copies TCP data from a pbuf into the buffer provided by an application using the netbuf- or socket layer. This function seems to be a bottle neck since it uses 2 loops and copies byte per byte.
|
Simon Goldschmidt <goldsimon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-02-26 | jifl | Open/Closed | Open | Closed | |
2007-02-26 | jifl | Attached File | - | Added lwip.netbuf.memcpy.patch, #12046 | |
Assigned to | kieranm | jifl | |||
2007-02-26 | kieranm | Assigned to | None | kieranm | |
2007-02-19 | kieranm | Priority | 5 - Normal | 3 - Low | |
2006-10-31 | goldsimon | Attached File | - | Added netbuf_copy_partial.patch, #11110 | |
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-d3ae.
Corresponding source code
I'm perfectly happy with that. Even better than what I did ;-)
Oh, and I wanted to say I really appreaciate you and Kieran are cleaning up the bugs & patches list. Only it's sad you two and Christiaan seem to be the only active developers in the project (or am I missing someone?)