patchlwIP - A Lightweight TCP/IP stack - Patches: patch #5741, bug in out of sequence queue...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5741: bug in out of sequence queue processing - incoming segment is larger than the old segment

Submitter:  Oleg Tyshev <olegreen>
Submitted:  Mon 12 Feb 2007 09:37:37 AM UTC
   
 
Category:  None Priority:  7 - High
Status:  Done Privacy:  Public
Assigned to:  kieranm Open/Closed:  Closed
Planned Release:  1.3.0

Jump to the original submission

Fri 13 Jul 2007 01:21:28 PM UTC, comment #7: 

Of course - sorry.  It compiled fine for me because I didn't have TCP_QUEUE_OOSEG.  Thanks for checking in the fix too.

Kieran Mansley <kieranm>
Group Member
Fri 13 Jul 2007 01:09:54 PM UTC, comment #6: 

Should replace "cseg." by" cseg->"

Frédéric Bernon <fbernon>
Group Member
Fri 13 Jul 2007 01:07:06 PM UTC, comment #5: 

Seems got a problem with this patch: I got build error on :

"src\core\tcp_in.c", line 1119: error: expression must have struct or union type
                    if (TCP_SEQ_GT(seqno + cseg.len, next->tcphdr->seqno)) {
                        ^
"src\core\tcp_in.c", line 1121: error: expression must have struct or union type
                      cseg.len = next->tcphdr->seqno - seqno;
                      ^
"src\core\tcp_in.c", line 1122: error: expression must have struct or union type
                      pbuf_realloc(cseg.p, cseg.len);
                                   ^
"src\core\tcp_in.c", line 1122: error: expression must have struct or union type
                      pbuf_realloc(cseg.p, cseg.len);
                                           ^

Frédéric Bernon <fbernon>
Group Member
Fri 13 Jul 2007 12:47:39 PM UTC, comment #4: 

Applied, sorry for the delay, and thanks for the fix.

Kieran Mansley <kieranm>
Group Member
Tue 24 Apr 2007 07:28:16 AM UTC, comment #3: 

Agreed.  I think it would be an improvement over what's there at least.  I'll take this and apply it.

Kieran Mansley <kieranm>
Group Member
Mon 23 Apr 2007 06:52:39 PM UTC, comment #2: 

I didn't test it, only looked through the code. From what I understand from the code, at least it looks as if we need some patch here. And what the patch does seems OK, too. But it would certainly need some testing. Only it's kind of hard to test...

Simon Goldschmidt <goldsimon>
Group administrator
Mon 19 Feb 2007 10:55:56 AM UTC, comment #1: 

Has anyone tested this?  It's a fairly critical bit of code so changes should be checked carefully.

Kieran Mansley <kieranm>
Group Member
Mon 12 Feb 2007 09:37:37 AM UTC, original submission:  

This patch fixes processing of the input segment in out of sequence queue.
(in actual source code we have memory leak)

Oleg Tyshev <olegreen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11968:  in_segm.patch added by olegreen (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by fbernon (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by olegreen (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-07-13 kieranm Open/ClosedOpen Closed
    2007-07-13 kieranm StatusNone Done
    2007-07-13 kieranm Planned ReleaseNone 1.3.0
    2007-04-24 kieranm Assigned toNone kieranm
    2007-02-12 olegreen Attached File- Added in_segm.patch, #11968

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code