lwIP - A Lightweight TCP/IP stack - Patches: patch #5764, api_lib.c cleanup: after patch...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5764: api_lib.c cleanup: after patch #5687
Submitter: | Dmitry Potapov <dpotapov> | ||
Submitted: | Wed 28 Feb 2007 05:49:17 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | fbernon | Open/Closed: | Closed |
Planned Release: | None |
Sun 04 Mar 2007 11:57:45 AM UTC, comment #5: |
Simon Goldschmidt <goldsimon> |
Sun 04 Mar 2007 08:24:52 AM UTC, comment #4: I think we should apply the change to remove the unnecessary underscore variables, but leave the api_msg in the netconn struct as it is. |
Kieran Mansley <kieranm> |
Sun 04 Mar 2007 12:17:10 AM UTC, comment #3: Simon,
|
Frédéric Bernon <fbernon> |
Thu 01 Mar 2007 07:03:41 AM UTC, comment #2: As it was me who submitted the original patch: I know I did that wrong, and I'd prefer the new version, too (#5764). When submitting the patch, I only wanted to have as little change as possible to point out the idea... |
Simon Goldschmidt <goldsimon> |
Wed 28 Feb 2007 06:07:16 PM UTC, comment #1: I'm agree with you, not about the underscore, but because avoiding the extra pointer give a simplest code...
|
Frédéric Bernon <fbernon> |
Wed 28 Feb 2007 05:49:17 PM UTC, original submission:
Declaring variables beginning with underscore is not good (the C standard reserves these names for vendor extentions)
|
Dmitry Potapov <dpotapov> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-03-05 | fbernon | Status | None | Done | |
Open/Closed | Open | Closed | |||
2007-03-04 | fbernon | Assigned to | None | fbernon | |
2007-02-28 | dpotapov | Attached File | - | Added MEMP_API_MSG_cleanup.patch, #12062 |
Powered by Savane 3.13-f8d8.
Corresponding source code
The patch should be included, yes. But I think api_msg should be left as it is. For me, it works fine the way it is now. Also, it would make the netconn struct bigger and I'd prefer to have the message on stack.