patchUnofficial CHM Specification - Patches: patch #5842, adds a ITBITS section tester to...


You are not allowed to post comments on this tracker with your current authentication level.

patch #5842: adds a ITBITS section tester to CHMTESTS

Submitter:  Francesco Montorsi <frm>
Submitted:  Sun 01 Apr 2007 10:30:01 PM UTC
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:
       No canned response available


Mon 02 Apr 2007 04:00:12 AM UTC, comment #1: 

Ah, can you split this up into two patches (this is where quilt gets useful)?

Please put some copyright headers in the #ITBITS test files. I'll do the same for the other files that are missing the info.

You may also want to test if the #ITBITS file length is != 12 (in the spec I mention VOICESDK.CHI was 12 zero bytes long).

Why alloc ui.length+1 bytes?

Please switch to using tabs instead of spaces - allows people the editor to have configurable indenting instead of restricted to the number or spaces in the file.

Looks good otherwise, excellent.

Also, be sure to refer to the CVS version of chmspec, there are some changes since the last release.

Paul Wise <pabs>
Project Administrator
Sun 01 Apr 2007 10:30:01 PM UTC, original submission:  

This patch:

 - adds itbits.c|h files and the test_ITBITS function
 - add a raw option processing to the chmtests binary and in particular the -v (verbose) option to provide some more feedback to the user.

Francesco Montorsi <frm>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #12368:  itbits.patch added by frm (5KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by pabs (Posted a comment)
  • -email is unavailable- added by frm (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.





    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-01 frm Attached File- Added itbits.patch, #12368

    Back to the top

    Powered by Savane 3.9