patchUnofficial CHM Specification - Patches: patch #5842, adds a ITBITS section tester to...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #5842: adds a ITBITS section tester to CHMTESTS

Submitted by:  Francesco Montorsi <frm>
Submitted on:  Sun 01 Apr 2007 10:30:01 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Mon 02 Apr 2007 04:00:12 AM UTC, comment #1:

Ah, can you split this up into two patches (this is where quilt gets useful)?

Please put some copyright headers in the #ITBITS test files. I'll do the same for the other files that are missing the info.

You may also want to test if the #ITBITS file length is != 12 (in the spec I mention VOICESDK.CHI was 12 zero bytes long).

Why alloc ui.length+1 bytes?

Please switch to using tabs instead of spaces - allows people the editor to have configurable indenting instead of restricted to the number or spaces in the file.

Looks good otherwise, excellent.

Also, be sure to refer to the CVS version of chmspec, there are some changes since the last release.

Paul Wise <pabs>
Project Administrator
Sun 01 Apr 2007 10:30:01 PM UTC, original submission:

This patch:

- adds itbits.c|h files and the test_ITBITS function
- add a raw option processing to the chmtests binary and in particular the -v (verbose) option to provide some more feedback to the user.

Francesco Montorsi <frm>

 

Attached Files
file #12368:  itbits.patch added by frm (5kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pabs (Posted a comment)
  • -unavailable- added by frm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 01 Apr 2007 10:30:01 PM UTCfrmAttached File-=>Added itbits.patch, #12368

    Back to the top


    Powered by Savane 3.1-cleanup