patchmldonkey, a multi-networks file-sharing client - Patches: patch #6269, BT: choke bug

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #6269: BT: choke bug

Submitted by:  bogeyman <bogeyman>
Submitted on:  Fri 16 Nov 2007 01:15:43 PM UTC  
 
Category: Bug fixesPriority: 7 - High
Status: PostponedAssigned to: None
Open/Closed: Open

(Jump to the original submission Jump to the original submission)

Mon 07 Jan 2008 08:42:59 PM UTC, comment #10:

bt-20071219.patch works well - but the computer has to be fast enough. With an AthlonXP-1800/256 MB RAM this is no problem. But on my P2-450/128 MB RAM the first version (bt-noblockfound.patch) is still the fastest one. The later patches seem to cause a higher cpu and memory consumption.

Eike Haberland <eikeh>
Thu 03 Jan 2008 05:13:13 PM UTC, comment #9:

Works well for me ( bt-20071219.patch ).

I have tested it with 3 torrents and now the download is faster then the 15-30%

But I get:
2008/01/03 18:06:09 [BT] [file_num 3][temp temp/BT-RJLQMCUYG5XQYX5HXIIWFI7M4OYC7 EFN] Error File "src/networks/bittorrent/bTGlobals.ml", line 0, characters 174-1 6: Assertion failed while handling MESSAGE: Piece 12486 2028929024[0]

Hire <hire>
Wed 19 Dec 2007 11:46:18 AM UTC, comment #8:

I append my actual patch, but this will need some more time and testing... Merry Christmas to all of you

(file #14663)

bogeyman <bogeyman>
Project Member
Wed 05 Dec 2007 03:50:41 PM UTC, comment #7:

Here are the results of my speed tests:

1. CentOS-5.1-i386-bin-1to6.torrent
2.9.2.CVS:
7h 37m 54s
bt-noblockfound6.patch and bt-notremovingpeers5.patch:
9h 50m 38s
12h 55m 33s
(extremely high cpu usage noticed with the latest patches.)

2. OOo_2.3.1_Win32Intel_install_de.exe.torrent
2.9.2.CVS:
8m 11s
5m 57s
5m 41s
bt-noblockfound6.patch and bt-notremovingpeers5.patch:
9m 7s
7m 24s
8m 18s
Old bt-noblockfound.patch:
5m 34s
5m 35s

Obviously there seems to be something wrong with the latest patches. The download speed was low and MLDonkey's cpu consumption was yery high (load average in top was always >0.7, without the patches it is usually <0.2 on my P2-450 box).

The last results confirm that the old bt-noblockfound.patch makes bittorrent downloads a little bit faster.

Eike Haberland <eikeh>
Sun 02 Dec 2007 10:32:45 PM UTC, comment #6:

With the latest patches applied my logfile was flooded by print_control messages once a minute (look at http://pastebin.org/10221). I got rid of them by commenting out the appropriate lines in bTClients.ml

I also noticed these messages:
2007/12/02 22:06:38 [BT] [file_num 2][temp temp/BT-CAMG7XRMICU5HKN7VV3T5KWGG6IXEWCO] Error File "src/networks/bittorrent/bTGlobals.ml", line 0, characters 174-16: Assertion failed while handling MESSAGE: Piece 136 0[16384]

Maybe I'll have time for some speed tests during the next week.

Eike Haberland <eikeh>
Sun 02 Dec 2007 07:51:12 PM UTC, comment #5:

here the last version, with some verbosity fixes and it rises the client timeout from 90 to 130 sec (pings are send every 120 secs). the second patch removes a peer after three failed retries. Good clients that disconnects are not removed. Feel free to test

(file #14536, file #14537)

bogeyman <bogeyman>
Project Member
Fri 30 Nov 2007 04:45:22 PM UTC, comment #4:

Working on a new patch, maybe including peer reconnects, coming soon ;)

bogeyman <bogeyman>
Project Member
Mon 19 Nov 2007 09:03:55 PM UTC, comment #3:

My first impression is that I get more sources but there is only a slightly increased download speed. (E.g. with this patch a torrent was downloaded in 22m 38s and the unpatched 2.9.2.CVS needed 25m 28s)

But now there are many, many lines with error messages like these in my logfile:

2007/11/19 20:20:24 [BT] [file_num 3][temp temp/BT-P6T6QGEWMTTULJDD3OSVW5T7AIJWNRB7] BTClient.get_from_client ERROR: can't find a block to download and file is not yet finished for file : xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

And this was already reported by orbit:
2007/11/19 20:28:14 [BT] [file_num 5][temp incoming/directories/xxxxxxxxxxxxxxxxxxxxxxx] Error File "src/networks/bittorrent/bTClients.ml", line 0, characters 590-14: Assertion failed while handling MESSAGE: Unchoke
2007/11/19 20:28:14 [BT] [file_num 5][temp incoming/directories/xxxxxxxxxxxxxxxxxxxxxxx] Error File "src/networks/bittorrent/bTClients.ml", line 0, characters 590-14: Assertion failed while handling MESSAGE: Choke

Eike Haberland <eikeh>
Sun 18 Nov 2007 02:07:42 PM UTC, comment #2:

That only means the swarmer is gone, when you received the choke. Since you finished the download, that should be no problem?! So this message could be verbose...

bogeyman <bogeyman>
Project Member
Sun 18 Nov 2007 01:37:52 AM UTC, comment #1:

download works for me, don't know if it's realy faster (it is fast)

only one thing when remove the download from the incoming i get this message, don't know whether it is related with the patch:

[BT] [file_num 11][temp /path/file.iso] Error File "src/networks/bittorrent/bTClients.ml", line 0, characters 590-14: Assertion failed while handling MESSAGE: Choke

orbit <orbit>
Fri 16 Nov 2007 01:15:43 PM UTC, original submission:

After been choked, no blocks can be found, we send empty request packets and the peer will timeout and be dropped. CommonSwarming.clear_uploader_intervals should not be called directly, CommonSwarming.update_uploader_intervals in update_client_bitmap does the magic.

This patch give me a huge speedup. Testers welcome ;)

bogeyman <bogeyman>
Project Member

 

Attached Files
file #14663:  bt-20071219.patch added by bogeyman (26kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by spiralvoice (Updated the item)
  • -unavailable- added by hire (Posted a comment)
  • -unavailable- added by eikeh (Posted a comment)
  • -unavailable- added by bogeyman (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 21 Dec 2010 05:55:52 AM UTCspiralvoiceStatusReady For Test=>Postponed
    Wed 19 Dec 2007 11:46:18 AM UTCbogeymanAttached File-=>Added bt-20071219.patch, #14663
    Wed 19 Dec 2007 11:45:39 AM UTCbogeymanAttached File#14537=>Removed
    Wed 19 Dec 2007 11:45:31 AM UTCbogeymanAttached File#14536=>Removed
    Wed 19 Dec 2007 11:45:12 AM UTCbogeymanAttached File#14536=>Removed
    Sun 02 Dec 2007 07:51:12 PM UTCbogeymanAttached File-=>Added bt-noblockfound6.patch, #14536
      Attached File-=>Added bt-notremovingpeers5.patch, #14537
      StatusNone=>Ready For Test
    Fri 30 Nov 2007 04:44:34 PM UTCbogeymanAttached File#14416=>Removed
    Fri 16 Nov 2007 01:15:44 PM UTCbogeymanAttached File-=>Added bt-noblockfound.patch, #14416

    Back to the top


    Powered by Savane 3.1-cleanup