patchlwIP - A Lightweight TCP/IP stack - Patches: patch #6348, Broadcast ARP packets in autoip

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6348: Broadcast ARP packets in autoip

Submitter:  Luca Ceresoli <lucaceresoli>
Submitted:  Mon 17 Dec 2007 09:01:17 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  fbernon Open/Closed:  Closed
Planned Release:  1.3.0

Jump to the original submission

Fri 18 Jan 2008 07:46:05 PM UTC, comment #6: 

I've applied the patch.

Jonathan Larmour <jifl>
Group Member
Fri 11 Jan 2008 09:26:07 AM UTC, comment #5: 

I tested your patch and it's very good to me.
Only one more little patch (const.patch) to fix a trivial compilation error ('a value of type "const unsigned char " cannot be assigned to an entity of type "u8_t "').


(file #14781)

Luca Ceresoli <lucaceresoli>
Mon 31 Dec 2007 01:24:55 PM UTC, comment #4: 

I have check in my changes. I also add a macro to test local-link addresses in ip_addr.h.

The change in etharp_raw could be removed, since all calls to etharp_raw use ethbroadcast for the "ethdst_addr" parameter. But it could be wrong in the future. There is only two tests and one store, so, I don't think it's a problem to check in like this.

Please, reopen it if I'm wrong...


Frédéric Bernon <fbernon>
Group Member
Sun 30 Dec 2007 03:08:40 AM UTC, comment #3: 

I attach a alternative patch for a better compliance (I hope). Other difference, I do the check to know if I have to use broadcast to send ARP packets before the loop (and not in the loop).

I wait comments before check in.


(file #14721)

Frédéric Bernon <fbernon>
Group Member
Sun 30 Dec 2007 01:33:05 AM UTC, comment #2: 

Isn't it a partial solution for the RFC3927 compliance? The patch fix ARP replies, but not ARP requests (see http://rfc.net/rfc3927.html#s2.5. ).

I think we should also fix in the same way "etharp_raw".

Comments?




Frédéric Bernon <fbernon>
Group Member
Thu 27 Dec 2007 07:12:44 PM UTC, comment #1: 

Dominik, what is your point of view on this patch?


Frédéric Bernon <fbernon>
Group Member
Mon 17 Dec 2007 09:01:17 AM UTC, original submission:  

The attached patch makes lwIP compliant to the following statement in RFC3927 (Link-Local).

"All ARP packets (replies as well as requests) that contain a Link-Local 'sender IP address' MUST be sent using link-layer broadcast instead of link-layer unicast.  This aids timely detection of duplicate addresses.".
(RFC3927, section 2.5)

Without this feature, duplicated addresses could be undetected for an undefined time even with ARP and IP traffic.

Luca Ceresoli <lucaceresoli>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #14781:  const.patch added by lucaceresoli (642B - application/octet-stream)
file #14721:  etharp.c.patch added by fbernon (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jifl (Posted a comment)
  • -email is unavailable- added by fbernon (Posted a comment)
  • -email is unavailable- added by lucaceresoli (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-01-11 lucaceresoli Attached File- Added const.patch, #14781
    2007-12-31 fbernon StatusNone Done
        Assigned toNone fbernon
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.3.0
    2007-12-30 fbernon Attached File- Added etharp.c.patch, #14721
    2007-12-17 lucaceresoli Attached File- Added autoip_arp_bcast.patch, #14642

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code