patchmldonkey, a multi-networks file-sharing client - Patches: patch #6629, Mail: Move hostname from subject...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6629: Mail: Move hostname from subject to body

Submitter:  daniel <eydaimon>
Submitted:  Mon 01 Sep 2008 07:35:39 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Mon 01 Sep 2008 07:36:57 AM UTC, comment #5: 

Committed 2008/09/01

spiralvoice <spiralvoice>
Group administrator
Mon 01 Sep 2008 07:35:39 AM UTC, comment #4: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client task tracker to your tracker.

The original report is still available at task #8478

Following are the information included in the original report:

[field #0]                  Item ID: 8478
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown task Field Display Type
[field #9]                 Category: Core
[field #10]             Submitted by: eydaimon
[field #11]              Assigned to: None
[field #12]             Submitted on: Fr 08 Aug 2008 12:01:02 CEST
[field #13]                  Summary: Mail: Move hostname from subject to body
[field #14]      Original Submission: Adding the sender mail (which isn't even a real email) to the subject is unnecessary and consumes much of the subject.

Current subject:

[mldonkey@whatever.hostname.you.run.mldonkey.on] file received - Somefilename_or_something.rar


How about shortening it to?:
mldonkey: Somefilename_or_something.rar completed.


[field #16]               Item Group: None
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #29]          Should Start On: Fr 08 Aug 2008 02:00:00 CEST
[field #30]    Should be Finished on: Fr 08 Aug 2008 02:00:00 CEST
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #58]     Custom Select Box #1: None
[field #59]     Custom Select Box #2: None
[field #60]     Custom Select Box #3: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Fri 08 Aug 2008 02:30:04 PM UTC, comment #3: 

Here's a patch with the host in the body instead.

FYI, I didn't submit the original patch with the task because I hadn't actually planned making one ;)


Index: commonInteractive.ml
===================================================================
RCS file: /sources/mldonkey/mldonkey/src/daemon/common/commonInteractive.ml,v
retrieving revision 1.105
diff -r1.105 commonInteractive.ml
346c346
<         Printf.sprintf "[mldonkey@%s] file received - %s" (Unix.gethostname ()) (file_best_name file)
---

>         Printf.sprintf "mldonkey - %s complete." (file_best_name file)

348c348
<         Printf.sprintf "mldonkey@%s, file received" (Unix.gethostname ())
---

>         Printf.sprintf "mldonkey - download complete."

368c368
<       Printf.sprintf "\r\nUser/Group: %s:%s\r\n" (file_owner file).user_name (user2_print_group (file_group file))
---

>       Printf.sprintf "\r\nUser/Group: %s:%s" (file_owner file).user_name (user2_print_group (file_group file))

370c370,374
<
---

>
>     let line7 =
>       Printf.sprintf "\r\nServer Host: %s\r\n" (Unix.gethostname ())
>     in
>

376c380
<         M.mail_body = line1 ^ line2 ^ line3 ^ line4 ^ line5 ^ (if admin then line6 else "");
---

>         M.mail_body = line1 ^ line2 ^ line3 ^ line4 ^ line5 ^ (if admin then line6 else "") ^ line7;


daniel <eydaimon>
Fri 08 Aug 2008 01:27:15 PM UTC, comment #2: 

Agreed. And as you suggest, I would find that information more suitable in the body of the message, and the most common scenario is a single instance, so no need to put it in every subject.

daniel <eydaimon>
Fri 08 Aug 2008 11:42:18 AM UTC, comment #1: 

IMHO it makes sense to see the hostname MLDonkey is running on in the commit mail because people may run MLDonkey on several machines. Without that information its difficult (by reading mail headers) to judge on which machine the finished file awaits further action.

If such information should be part of the subject or be part of the body is another question, for me both is ok.

Small note: You could have attached your patch to this task, now they are seperate tracker entries.

Copied patch from https://savannah.nongnu.org/patch/?6600#comment0

Index: src/daemon/common/commonInteractive.ml
===================================================================
RCS file: /sources/mldonkey/mldonkey/src/daemon/common/commonInteractive.ml,v
retrieving revision 1.105
diff -r1.105 commonInteractive.ml
346c346
< Printf.sprintf "[mldonkey@%s] file received - %s" (Unix.gethostname ()) (file_best_name file)
---

> Printf.sprintf "mldonkey - %s complete." (file_best_name file)


348c348
< Printf.sprintf "mldonkey@%s, file received" (Unix.gethostname ())
---

> Printf.sprintf "mldonkey - download complete."


spiralvoice <spiralvoice>
Group administrator
Mon 01 Sep 2008 07:35:39 AM UTC, original submission:  

Adding the sender mail (which isn't even a real email) to the subject is unnecessary and consumes much of the subject.

Current subject:

[mldonkey@whatever.hostname.you.run.mldonkey.on] file received - Somefilename_or_something.rar


How about shortening it to?:
mldonkey: Somefilename_or_something.rar completed.


daniel <eydaimon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16415:  mail_subject.patch added by spiralvoice (2KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by eydaimon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-09-01 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2008-09-01 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, task #8478 mldonkey, a multi-networks file-sharing client, patch #6629

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code