lwIP - A Lightweight TCP/IP stack - Patches: patch #6683, Customizable AUTOIP...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6683: Customizable AUTOIP "seed" address
Submitter: | Luca Ceresoli <lucaceresoli> | ||
Submitted: | Wed 03 Dec 2008 11:48:27 AM UTC | ||
Category: | None | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Fri 19 Dec 2008 06:17:27 PM UTC, comment #7: |
Simon Goldschmidt <goldsimon> |
Fri 12 Dec 2008 09:45:34 AM UTC, comment #6: One more little patch, attached. It fixes a subtle bug on operator precedence (and a typo).
|
Luca Ceresoli <lucaceresoli> |
Wed 10 Dec 2008 05:09:32 PM UTC, comment #5: That's great, I've checked it in (plus an assert the range is correct afterwards). As I can only compile it, not test it, I would be pleased if you could try it. |
Simon Goldschmidt <goldsimon> |
Tue 09 Dec 2008 01:57:50 PM UTC, comment #4: You are 100% right.
|
Luca Ceresoli <lucaceresoli> |
Thu 04 Dec 2008 06:36:28 PM UTC, comment #3: The reason I change the seed to be an offset is to make sure we stay in the given range for autoip. I admin there's an overbiasing of 0x100, but I don't think the check is double: If the address given by LWIP_AUTOIP_CREATE_SEED_ADDR is too high, the calculations below can fail to get the address into the autoip range.
|
Simon Goldschmidt <goldsimon> |
Thu 04 Dec 2008 11:33:47 AM UTC, comment #2:
Much cleaner, but I don't like the new meaning you gave to the seed.
The "random" part was removed elsewhere, but not here.
Also, these ifs should not be here since they are present a few lines later (where also the effect of tried_llipaddr is taken into account).
|
Luca Ceresoli <lucaceresoli> |
Wed 03 Dec 2008 03:16:01 PM UTC, comment #1: That's a good idea. The current implementation 'leaves room for improvement'...
|
Simon Goldschmidt <goldsimon> |
Wed 03 Dec 2008 11:48:27 AM UTC, original submission:
The current AUTOIP implementation generates the first address to probe from the two LSBs of the MAC address.
|
Luca Ceresoli <lucaceresoli> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-12-19 | goldsimon | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2008-12-12 | lucaceresoli | Attached File | - | Added autoip-seed2.patch, #17034 | |
2008-12-03 | goldsimon | Assigned to | None | goldsimon | |
2008-12-03 | goldsimon | Status | None | Ready For Test | |
2008-12-03 | lucaceresoli | Attached File | - | Added autoip-seed.patch, #16979 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Yep, checked that in. And sorry for forgetting the s in your name!