patchlwIP - A Lightweight TCP/IP stack - Patches: patch #6745, Ethernet interface drivers for...


You are not allowed to post comments on this tracker with your current authentication level.

patch #6745: Ethernet interface drivers for CS8900A, MCF5223x

Submitted by:  Mike Kleshov <kleshov>
Submitted on:  Sat 14 Feb 2009 02:04:25 PM UTC  
Category:  None Priority:  3 - Low
Status:  None Privacy:  Public
Assigned to:  Mike Kleshov <kleshov> Open/Closed:  Closed
Planned Release:  None

( Jump to the original submission)

Sun 10 Jan 2010 06:32:50 PM UTC, comment #10: 

I've just uploaded the drivers to the download area (subdirectory 'drivers/1.3.0' as I think they were written for 1.3.X - correct me if I'm wrong) and started a wiki page for these things:

Mike, thanks for getting us started with this and please keep us up-to-date on any bugfixes of these drivers via the lwip-devel mailing list or by changing the wiki yourself and uploading drivers to another location).

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 07 May 2009 03:26:47 PM UTC, comment #9: 
Kieran Mansley <kieranm>
Project Member
Thu 07 May 2009 03:21:12 PM UTC, comment #8: 

Seems like the best idea so far...

Mike, do you want to host the file yourself or put it in the download section here? Kieran, how do we put things there? We'd need a subdirectory for ports and drivers.

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 07 May 2009 03:09:32 PM UTC, comment #7: 

How about we keep the descriptions in wikia and then link to wherever the files are hosted.  This allows the files to either be hosted by whoever contributes them (if they want to make sure there is always an up to date version available for example) or we can put things in the download area on savannah.

Kieran Mansley <kieranm>
Project Member
Thu 07 May 2009 02:05:03 PM UTC, comment #6: 

Wikia does not seem to allow uploading files except for pictures. Does anyone have another idea where to put things like this? Does savannah provide something here? A subdirectory in the downloads section would be a start, but a description page instead of a file list would be better, I guess.

Simon Goldschmidt <goldsimon>
Project Administrator
Tue 17 Feb 2009 11:53:06 AM UTC, comment #5: 

Yes - Simon summarises my view very well.  Such things are very welcome even without a maintainer, but not in CVS.  Of course if there is a maintainer (which should be a very easy job) that is the best thing, but if not we should use a download area on the homepage or wiki for things like this that are known to work at one point in time, but won't be supported in the future.

The problem we used to have was that we could never tag the contrib module as working against an lwIP release as the ports weren't maintained, and so contrib got very badly out of sync with the core of lwIP.

Kieran Mansley <kieranm>
Project Member
Mon 16 Feb 2009 08:38:33 PM UTC, comment #4: 

> It's probably a question of balance: a small number of
> high-quality ports/drivers vs. a large number of lower-quality
> ports/drivers.

That's exactly the point. I also like the prefab ports for the micrium OS (already used them), but they have an OS to sell, what we don't, so they have the time and money to change all the ports when the API changes.

In fact, the real point is not to have high-quality code but to ensure a driver that is in contrib really works. And b) includes re-testing the driver really works after changing an lwIP API (like in ethernetif.c 1.112 between lwIP 1.2.0. and 1.3.0). These can be simpler changes that can be reviewed while compiling or more complex things which require testing it with real hardware. Kieran's policy is kind of strict here (only add code where someone steps up as an active maintainer), and I must say I agree: there can be other places on the web (lwIP wiki) were drivers/ports for a specific version can be hosted - CVS gives the impression of being up to date, which is isn't if not maintained.

Simon Goldschmidt <goldsimon>
Project Administrator
Mon 16 Feb 2009 08:06:46 PM UTC, comment #3: 

I agree with Bill's comment.
Helping as many people as possible in their work is a noble goal, and having a large collection of contributed ports/drivers helps advance towards this goal.
It's probably a question of balance: a small number of high-quality ports/drivers vs. a large number of lower-quality ports/drivers. Right now, the balance is closer to the former rather than the latter...

Mike Kleshov <kleshov>
Project MemberIn charge of this item.
Mon 16 Feb 2009 07:51:39 PM UTC, comment #2: 

If the skeleton Ethernetif.c is adhered to, why would (b) apply?

IMO, one thing that e.g. Micrium does very well where I wish lwIP would also is to provide a large contrib section of ports for various processors and Ethernet controllers.

If rules for contributing a port existed requiring using the driver skeleton and its naming conventions and these rules are followed, then we should be able to have a more complete number of ports that don't break with lwIP updates.

This would also allow a place for assembly language checksum routines which go a long way to speeding up a port (and potentially making it smaller too).

Bill Auerbach <billauerbach>
Sat 14 Feb 2009 07:59:21 PM UTC, comment #1: 

The procedure for contrib is: it only goes in if there is an active maintainer, mainly meaning:

a) being responsible for fixes when bugs appear and
b) making sure the driver still works when other parts of lwIP change, i.e. keeping it up-to-date

If you are willing to do that, we can commit the new driver into CVS (if it meets the lwIP coding style).

Simon Goldschmidt <goldsimon>
Project Administrator
Sat 14 Feb 2009 02:04:25 PM UTC, original submission:  

I am posting the drivers here since some people on the lwip-users mailing list expressed interest. The code could probably go into the contrib CVS module, I just don't know how to accomodate the structure of contrib for this. The code probably needs some cleaning up: right now the coding style is a mixture of lwip's and mine. Copyright terms are the same as for the rest of lwip code.
If someone could comment how best to proceed with the patch, please do.

Mike Kleshov <kleshov>
Project MemberIn charge of this item.


Attached Files
file #17448:  cs8900if.h added by kleshov (332B - application/octet-stream)
file #17449:  cs8900if.c added by kleshov (13KiB - text/x-csrc)
file #17450:  mcf5223xif.h added by kleshov (324B - application/octet-stream)
file #17451:  mcf5223xif.c added by kleshov (15KiB - text/x-csrc)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by billauerbach (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kleshov (Submitted the item)
  • -email is unavailable- added by kleshov (Ethernet interface drivers for CS8900A, MCF5223x)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-10 goldsimon Open/ClosedOpen => Closed
    2009-02-14 kleshov Attached File- => Added cs8900if.h, #17448
        Attached File- => Added cs8900if.c, #17449
        Attached File- => Added mcf5223xif.h, #17450
        Attached File- => Added mcf5223xif.c, #17451
        Carbon-Copy- => Added

    Back to the top

    Powered by Savane 3.5