patchAVR C Runtime Library - Patches: patch #7073, util/crc16.h: reduce xmodem-crc...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7073: util/crc16.h: reduce xmodem-crc from 25 to 22 assembler instructions

Submitter:  Hans-Christoph Wirth <hcw>
Submitted:  Mon 25 Jan 2010 06:00:46 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  joerg_wunsch Open/Closed:  Closed

Fri 13 May 2011 05:52:09 PM UTC, comment #2: 

Closing for lack of required feedback.

Eric Weddington <arcanum>
Group administrator
Tue 08 Jun 2010 11:12:59 AM UTC, comment #1: 

Did you actually test it?

crc16-3.s: Assembler messages:
crc16-3.s:130: Error: register number above 15 required

This comes from:

andi   _tmp_reg_,0xf0

Please resubmit it.  Before, please test against the testcase
[tests/simulate/]util/crc16-3.c.

Joerg Wunsch <joerg_wunsch>
Group administrator
Mon 25 Jan 2010 06:00:46 PM UTC, original submission:  

The attached patch proposal to the xmodem-crc code reduces the instruction number from 25 to 22 instructions while the calculation is supposed to remain equivalent.

Hans-Christoph Wirth <hcw>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #19547:  crc16.patch added by hcw (4KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arcanum (Posted a comment)
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by hcw (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-05-13 arcanum StatusNeed Info Wont Do
        Open/ClosedOpen Closed
    2010-06-08 joerg_wunsch StatusNone Need Info
        Assigned toNone joerg_wunsch
    2010-01-25 hcw Attached File- Added crc16.patch, #19547

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code