patchBos Wars - Patches: patch #7116, Initialize unit types when the...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7116: Initialize unit types when the first unit is created

Submitter:  Kalle Olavi Niemitalo <kon>
Submitted:  Sat 13 Mar 2010 03:53:00 AM UTC
   
 
Open/Closed:  Closed Status:  Wont Do
Assigned to:  feb

Sat 24 Apr 2010 07:12:04 PM UTC, comment #5: 

Sorry, I meant patch #7173.

Kalle Olavi Niemitalo <kon>
Group Member
Sat 24 Apr 2010 07:10:56 PM UTC, comment #4: 

I filed the error check as patch #7116.

Kalle Olavi Niemitalo <kon>
Group Member
Sat 10 Apr 2010 10:30:37 AM UTC, comment #3: 

Yes, the extra error checks are welcome. Can you make a seperate patch for them ?  Thenks.

François Beerten <feb>
Group administrator
Sat 03 Apr 2010 08:10:26 AM UTC, comment #2: 

I think the added error checks in file #19926 would be worthwhile anyway.  Would you like a separate patch just for those?

Kalle Olavi Niemitalo <kon>
Group Member
Sun 14 Mar 2010 09:38:05 PM UTC, comment #1: 

Defining units in maps breaks other things, like saved games and the editor. Better to avoid doing such dangerous things.

François Beerten <feb>
Group administrator
Sat 13 Mar 2010 03:53:00 AM UTC, original submission:  

Bos Wars initialized unit types before loading the map setup file, so it did not properly initialize any unit types defined in that file.  Initialize them when the first unit of the map is created, and raise a Lua error if someone tries to define more unit types after that.  Also, raise a Lua error if someone tries to define variables after defining unit types.

It would be nicer to initialize each unit type as it is defined, but that scheme would not support cyclic relations in build restrictions.

This patch is for trunk r9676.

Kalle Olavi Niemitalo <kon>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #19926:  0001-Initialize-unit-types-when-the-first-unit-is-created.patch added by kon (3KiB - text/x-patch - [PATCH] Initialize unit types when the first unit is created)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by feb (Posted a comment)
  • -email is unavailable- added by kon (Submitted the item)
  •  

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-24 kon Open/ClosedOpen Closed
        StatusNone Wont Do
    2010-04-10 feb Assigned toNone feb
    2010-03-13 kon Attached File- Added 0001-Initialize-unit-types-when-the-first-unit-is-created.patch, #19926

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code