patchmldonkey, a multi-networks file-sharing client - Patches: patch #7161, bw_toggle: Add options...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7161: bw_toggle: Add options "high" and "low"

Submitter:  Andreas Volz <andreas99>
Submitted:  Thu 08 Apr 2010 07:03:12 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Thu 08 Apr 2010 07:05:19 PM UTC, comment #10: 

committed 2010/04/08

spiralvoice <spiralvoice>
Group administrator
Thu 08 Apr 2010 07:03:12 PM UTC, comment #9: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client task tracker to your tracker.

The original report is still available at task #10195

Following are the information included in the original report:

[field #0]                  Item ID: 10195
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #9]                 Category: Core
[field #10]             Submitted by: andreas99
[field #11]              Assigned to: None
[field #12]             Submitted on: Tue 23 Feb 2010 09:57:22 PM CET
[field #13]                  Summary: bw_toggle: Add options "high" and "low"
[field #14]      Original Submission: This patch helps me to better set min/max download speed from a program that detects the idle status of my system. Currently min/max settings are hard coded. I've seen no better way as the setting values from config file are always overwritten. Maybe you find a better way to make min/max configurable.
[field #16]               Item Group: None
[field #17]                   Status: Ready For Test
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #29]          Should Start On: Tue 06 Apr 2010 12:00:00 AM CEST
[field #30]    Should be Finished on: Tue 06 Apr 2010 12:00:00 AM CEST
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #58]     Custom Select Box #1: None
[field #59]     Custom Select Box #2: None
[field #60]     Custom Select Box #3: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Tue 06 Apr 2010 08:17:35 PM UTC, comment #8: 

Looks reasonable, and is possible to extend the argument to numbers in case we decide to support more than 2 speed profiles in future.

ygrek <ygrek>
Group Member
Tue 06 Apr 2010 07:21:37 PM UTC, comment #7: 

What about the attached patch?

It extends the command bw_toggle with an optional parameter, "high" or "low". If bw_toggle is called without parameter, it behaves like before.

If "high" is added, the _2 option set is used if max_opened_connections_2 is higher than max_opened_connections.
Otherwise the option values are kept.

If "low" is added, the _2 option set is used if max_opened_connections_2 is lower than max_opened_connections.
Otherwise the option values are kept.

(file #20139)

spiralvoice <spiralvoice>
Group administrator
Sun 04 Apr 2010 11:03:51 AM UTC, comment #6: 

So what is a consensus on this? We could have additional argument for bw_toggle to specify which download profile to use (and toggle when no parameter supplied (as it is now)). Anyway the solution with netcat looks pretty reasonable to me.

ygrek <ygrek>
Group Member
Wed 24 Feb 2010 07:39:49 PM UTC, comment #5: 

bw_toggle isn't a good idea as it only toggles, but from extern script I could never be sure if it toggles min->max or max->min. It depends on the current state.

Andreas Volz <andreas99>
Tue 23 Feb 2010 08:57:22 PM UTC, comment #4: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client patch tracker to your tracker.

The original report is still available at patch #7098

Following are the information included in the original report:

[field #0]                  Item ID: 7098
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown patch Field Display Type
[field #9]                 Category: None
[field #10]             Submitted by: andreas99
[field #11]              Assigned to: None
[field #12]             Submitted on: So 21 Feb 2010 14:57:21 CET
[field #13]                  Summary: Min/Max bandwith setting
[field #14]      Original Submission: This patch helps me to better set min/max download speed from a program that detects the idle status of my system. Currently min/max settings are hard coded. I've seen no better way as the setting values from config file are always overwritten. Maybe you find a better way to make min/max configurable.
[field #16]               Item Group: None
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #58]     Custom Select Box #1: None
[field #59]     Custom Select Box #2: None
[field #60]     Custom Select Box #3: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Tue 23 Feb 2010 08:57:06 PM UTC, comment #3: 

What about using command bw_toggle?

From ChangeLog.old:

2006/10/23
5474: New command bw_toggle (ported from Knockers Mulus client)
- two new options: max_hard_upload_rate_2 and max_hard_download_rate_2
- new command bw_toggle, quickly switch between two bandwidth options

spiralvoice <spiralvoice>
Group administrator
Mon 22 Feb 2010 09:29:55 PM UTC, comment #2: 

Hm, I didn't know this command. Maybe this helps me. If yes the patch isn't needed any more.

thanks for the hint.

Andreas Volz <andreas99>
Sun 21 Feb 2010 03:05:27 PM UTC, comment #1: 

Hi,

Don't know if this helps, but I use a simple nc command to set mldonkey bandwidth :


#!/bin/sh

DOWNLOAD=$1
UPLOAD=$2

nc localhost 4000 &>/dev/null <<END
auth admin password
ansi no
set max_hard_download_rate $DOWNLOAD
set max_hard_upload_rate $UPLOAD
q
END

Alex <alesc>
Thu 08 Apr 2010 07:03:12 PM UTC, original submission:  

This patch helps me to better set min/max download speed from a program that detects the idle status of my system. Currently min/max settings are hard coded. I've seen no better way as the setting values from config file are always overwritten. Maybe you find a better way to make min/max configurable.

Andreas Volz <andreas99>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20139:  bw_toggle.patch added by spiralvoice (2KiB - plain/text)
file #19765:  min_max.patch added by andreas99 (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ygrek (Posted a comment)
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by alesc (Posted a comment)
  • -email is unavailable- added by andreas99 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-08 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2010-04-08 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, task #10195 mldonkey, a multi-networks file-sharing client, patch #7161

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code