lwIP - A Lightweight TCP/IP stack - Patches: patch #7449, allow tcpip callback from...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7449: allow tcpip callback from interrupt with static memory message
Submitter: | Stephane Lesage <slesage> | ||
Submitted: | Sat 22 Jan 2011 11:28:28 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Sat 14 May 2011 12:31:26 PM UTC, comment #14: |
Simon Goldschmidt <goldsimon> |
Fri 13 May 2011 08:43:00 AM UTC, comment #13:
|
Simon Goldschmidt <goldsimon> |
Fri 13 May 2011 08:37:01 AM UTC, comment #12: My apologies: I forgot about this when making the release. Lets get it in now so it can't be forgotten any longer. It might be worth checking this in before the IPv6 code so Stephane at least has a point in CVS (albeit not an official release) that is close to 1.4.0, doesn't have any new unstable code added, and yet has this code included. |
Kieran Mansley <kieranm> |
Fri 13 May 2011 07:37:24 AM UTC, comment #11: Sadly, this hasn't made it into 1.4.0, either. I'll check it in these days, now since 1.4.0 is out. |
Simon Goldschmidt <goldsimon> |
Thu 31 Mar 2011 11:37:48 AM UTC, comment #10:
|
Stephane Lesage <slesage> |
Wed 30 Mar 2011 10:08:43 PM UTC, comment #9: Your patch is good globally, but there's a typo:
|
Stephane Lesage <slesage> |
Wed 30 Mar 2011 08:14:42 PM UTC, comment #8: I'd like to review this before committing, but might not get the chance before tomorrow. Please hold off committing before then |
Kieran Mansley <kieranm> |
Wed 30 Mar 2011 05:14:50 PM UTC, comment #7: ... and here it is. I'll check it in tomorrow unless there are any objections ;-) |
Simon Goldschmidt <goldsimon> |
Wed 30 Mar 2011 04:49:46 PM UTC, comment #6:
|
Simon Goldschmidt <goldsimon> |
Tue 29 Mar 2011 08:45:33 PM UTC, comment #5:
|
Stephane Lesage <slesage> |
Tue 29 Mar 2011 07:33:29 PM UTC, comment #4: I think the idea of this patch is good since it terms of speedup. However, I think the function tcpip_trypost() would have to be changed to something more like tcpip_callback() because it should
|
Simon Goldschmidt <goldsimon> |
Tue 29 Mar 2011 07:27:07 PM UTC, comment #3: A patch like this would have made it clearer what you wanted. |
Simon Goldschmidt <goldsimon> |
Tue 29 Mar 2011 09:38:24 AM UTC, comment #2:
|
Stephane Lesage <slesage> |
Tue 29 Mar 2011 09:01:35 AM UTC, comment #1: I don't understand the renaming of the message types, which seems to be the bulk of this patch. Can you explain what's going on here? I get the feeling that the pool/stat bit is really a flag rather than a whole new set of types. Perhaps we need a flags field in the tcpip_msg structure. |
Kieran Mansley <kieranm> |
Sat 22 Jan 2011 11:28:28 PM UTC, original submission:
|
Stephane Lesage <slesage> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2011-05-14 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2011-03-30 | goldsimon | Attached File | - | Added tcpip_trycallback_static.patch, #23061 | |
2011-03-29 | goldsimon | Attached File | - | Added tcpip-trypost-staticmessages_lessrenaming.patch, #23054 | |
2011-01-22 | slesage | Attached File | - | Added tcpip-trypost-staticmessages.patch, #22497 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Checked in.