patchlwIP - A Lightweight TCP/IP stack - Patches: patch #7536, Fix bad MEM_SIZE check when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7536: Fix bad MEM_SIZE check when setting type of mem_size_t

Submitter:  Johan Englund <johanenglund>
Submitted:  Thu 28 Apr 2011 09:02:26 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Fri 29 Apr 2011 11:45:00 AM UTC, comment #3: 


> IMO lower-case l should never be used for long constants.


In terms of readability, I agree and have changed it that way.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 28 Apr 2011 01:06:09 PM UTC, comment #2: 

Right you are! A bit too trigger happy, so sorry!

Johan Englund <johanenglund>
Thu 28 Apr 2011 12:26:42 PM UTC, comment #1: 

That's an l (L) not a 1 (one).  IMO lower-case l should never be used for long constants.

Bill Auerbach <billauerbach>
Thu 28 Apr 2011 09:02:26 AM UTC, original submission:  

Compares with 640001 instead of 64000.

Johan Englund <johanenglund>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #23317:  mem.h.patch added by johanenglund (61B - application/octet-stream - Patch to fix bug.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by billauerbach (Posted a comment)
  • -email is unavailable- added by johanenglund (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-04-29 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2011-04-28 johanenglund Attached File- Added mem.h.patch, #23317

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code