patchmldonkey, a multi-networks file-sharing client - Patches: patch #7661, Fix compilation with current...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7661: Fix compilation with current libnatpmp

Submitted by:  Tathar <tathar>
Submitted on:  Thu 03 Nov 2011 04:38:20 PM UTC
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Duplicate Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sun 24 Jun 2012 08:12:07 AM UTC, comment #5: 

please try current CVS which includes patch #7805

spiralvoice <spiralvoice>
Project Administrator
Tue 17 Apr 2012 09:29:14 PM UTC, comment #4: 

Reports build error on Mac 10.7 Xcode 4.3:

Undefined symbols for architecture x86_64:
  "_pthread_mutex_timedlock", referenced from:
      _upnpNatpmpThread in upnp_stubs.o
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking
make: *** [mlnet] Error 2

mldonkey 3.1.0 with all 3.1.1 patches but 7727 (which breaks compilation on Mac 10.7.x) & patch (file #25593, file #25594) in comment #3.

congifure log (seems all fine):
https://gist.github.com/2409161

build log:
https://gist.github.com/2409141

Thruth Wang <thruth>
Thu 05 Apr 2012 07:46:33 PM UTC, comment #3: 

Attached you will find two patches which superseed initnatpmp.patch:

- upnp_update_configure.patch updates MLDonkey configure to compile recent version of upnp code (miniupnpc-1.6 & libnatpmp-20110808) when using --enable-force-upnp-natpmp

- openbsd_patch-src_utils_net_upnp_stubs_c is taken from OpenBSDs MLDonkey port ( http://www.openbsd.org/cgi-bin/cvsweb/ports/net/mldonkey/stable/patches/ ) to fix compilation issues with newer upnp code. MLDonkey compilation will break with older upnp code, but I guess no one is interested in it anymore ;)

Patch is compile/link tested, reports of working functionality are welcome.

(file #25593, file #25594)

spiralvoice <spiralvoice>
Project Administrator
Thu 03 Nov 2011 04:38:20 PM UTC, comment #2: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #34726

Following are the information included in the original report:

[field #0]                  Item ID: 34726
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: None
[field #10]             Submitted by: tathar
[field #11]              Assigned to: None
[field #12]             Submitted on: Mi 02 Nov 2011 13:44:24 CET
[field #13]                  Summary: Fix compilation with current libnatpmp
[field #14]      Original Submission: make error if option "--enable-upnp-natpmp" enabled

rc/utils/net/upnp_stubs.c:504:9: error: too few arguments to function ‘initnatpmp’
/usr/include/natpmp.h:144:13: note: declared here
[field #16]               Item Group: Compilation problem
[field #17]                   Status: Need Info
[field #18]        Component Version: None
[field #19]         Operating System: Linux
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 3.1.0
[field #34]                  Release: 3.1.0 (cvs)
[field #58]          Binaries Origin: CVS / Self compiled
[field #59]                 CPU type: x86_64
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Project Administrator
Thu 03 Nov 2011 04:38:19 PM UTC, comment #1: 

Your patch will fix compilation with current libnatpmp-20101211, will this still work with libnatpmp-20100202?

spiralvoice <spiralvoice>
Project Administrator
Thu 03 Nov 2011 04:38:20 PM UTC, original submission:  

make error if option "--enable-upnp-natpmp" enabled

rc/utils/net/upnp_stubs.c:504:9: error: too few arguments to function ‘initnatpmp’
/usr/include/natpmp.h:144:13: note: declared here

Tathar <tathar>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25593:  upnp_update_configure.patch added by spiralvoice (2KiB - application/force-download)
file #25594:  openbsd_patch-src_utils_net_upnp_stubs_c added by spiralvoice (2KiB - application/octet-stream)
file #24273:  initnatpmp.patch added by tathar (569B - text/x-patch - this patch solving error)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by thruth (Posted a comment)
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by tathar (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-06-24 spiralvoice StatusReady For Test => Duplicate
        Open/ClosedOpen => Closed
    2012-04-05 spiralvoice Attached File- => Added upnp_update_configure.patch, #25593
        Attached File- => Added openbsd_patch-src_utils_net_upnp_stubs_c, #25594
        StatusNeed Info => Ready For Test
    2012-03-10 spiralvoice CategoryNone => Bug fixes
        StatusNone => Need Info
    2011-11-03 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #34726 => mldonkey, a multi-networks file-sharing client, patch #7661

    Back to the top


    Powered by Savane 3.9