patchmldonkey, a multi-networks file-sharing client - Patches: patch #7727, Makefile: call `$(CPP) -x c`...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #7727: Makefile: call `$(CPP) -x c` instead of `cpp`

Submitted by:  spiralvoice <spiralvoice>
Submitted on:  Wed 22 Feb 2012 08:20:14 PM UTC  
 
Category: Bug fixesPriority: 5 - Normal
Status: DoneAssigned to: ygrek <ygrek>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Sun 17 Jun 2012 12:49:23 PM UTC, comment #8:

see https://savannah.nongnu.org/bugs/?36654

ygrek <ygrek>
Project MemberIn charge of this item.
Thu 14 Jun 2012 01:09:08 AM UTC, comment #7:

This workaround fixes a compilation error on OSX Lion. Reporting this for Homebrew, a package installed for Macs.

In Makefile and config/Makefile.in, I replace

@$(CPP) -x c

with

cpp

Please consider adjusting your code. Note I also tried this without success: `@$(CPP) -xc`

Thanks, nibbles

nibbles <github_2bits>
Tue 17 Apr 2012 05:37:02 PM UTC, comment #6:

Seems fine. No error.

Just like provoking 'cpp'. New line to type in after enter.

Thruth Wang <thruth>
Tue 17 Apr 2012 05:29:45 PM UTC, comment #5:

Try invoking it without a space - i.e. "cpp -xc".

ygrek <ygrek>
Project MemberIn charge of this item.
Tue 17 Apr 2012 05:18:46 PM UTC, comment #4:

That's really beyond my knowledge. What can I do to find out/debug? I happen to have time to labour.

Thruth Wang <thruth>
Tue 17 Apr 2012 04:34:19 PM UTC, comment #3:

It seems that patch #4883 might be responsible:
http://cvs.savannah.gnu.org/viewvc/mldonkey/config/configure.in?root=mldonkey&r1=1.255&r2=1.256

spiralvoice <spiralvoice>
Project Administrator
Tue 17 Apr 2012 03:31:22 PM UTC, comment #2:

Unfortunately this patch breaks mldonkey from compiling on Mac OS X 10.7.3 + Xcode 4.3.2.

$ make
sed: -o: No such file or directory
sed: src/utils/cdk/tar.ml: No such file or directory
i686-apple-darwin11-llvm-gcc-4.2: c: No such file or directory
i686-apple-darwin11-llvm-gcc-4.2: c: No such file or directory
i686-apple-darwin11-llvm-gcc-4.2: warning: '-x -x' after last input file has no effect
i686-apple-darwin11-llvm-gcc-4.2: no input files

it seems more likely a bug in Mac's cpp, even though "-x c" is mentioned in 'man cpp' :

$ cpp -x c
i686-apple-darwin11-llvm-gcc-4.2: c: No such file or directory
i686-apple-darwin11-llvm-gcc-4.2: c: No such file or directory
i686-apple-darwin11-llvm-gcc-4.2: warning: '-x -x' after last input file has no effect
i686-apple-darwin11-llvm-gcc-4.2: no input files

However without this patch mldonkey builds correctly on Mac. Would there be any workarounds?

Thruth Wang <thruth>
Wed 22 Feb 2012 08:23:52 PM UTC, comment #1:

committed 2012/02/22

spiralvoice <spiralvoice>
Project Administrator
Wed 22 Feb 2012 08:20:14 PM UTC, original submission:

patch by ygrek:
http://repo.or.cz/w/mldonkey.git/commitdiff/79a91c4907f8c7d0bf24a6ef702120294dd7306e

spiralvoice <spiralvoice>
Project Administrator

 

Attached Files
file #25117:  cpp.patch added by spiralvoice (535B - unknown/unknown)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by github_2bits (Posted a comment)
  • -unavailable- added by ygrek (Posted a comment)
  • -unavailable- added by thruth (Posted a comment)
  • -unavailable- added by spiralvoice (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 17 Jun 2012 12:49:23 PM UTCygrekStatusNeed Info=>Done
      Assigned toNone=>ygrek
      Open/ClosedOpen=>Closed
    Tue 17 Apr 2012 04:34:19 PM UTCspiralvoiceStatusDone=>Need Info
      Open/ClosedClosed=>Open
    Wed 22 Feb 2012 08:23:52 PM UTCspiralvoiceStatusWorks For Me=>Done
      Open/ClosedOpen=>Closed
    Wed 22 Feb 2012 08:20:14 PM UTCspiralvoiceAttached File-=>Added cpp.patch, #25117

    Back to the top


    Powered by Savane 3.1-cleanup