patchCERTI - Patches: patch #8445, LWIP IP Re-assembly timer...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8445: LWIP IP Re-assembly timer optimization

Submitter:  Nirav Desai <niravisneo>
Submitted:  Mon 05 May 2014 11:16:55 AM UTC
   
 
Category:  None Priority:  6
Status:  Invalid Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Discussion locked!

Thu 02 Apr 2015 01:13:16 PM UTC, comment #2: 

Closing the invalid bug.

Eric NOULARD <erk>
Group administrator
Mon 05 May 2014 11:43:57 AM UTC, comment #1: 

Hi Nirav,

I guess you posted your report on the wrong project.
Your patch wad filed to "CERTI":
https://savannah.nongnu.org/projects/certi/

while you seem to target LWip:
https://savannah.nongnu.org/projects/lwip

I let you file the patch to lwip before I close this one.

Eric NOULARD <erk>
Group administrator
Mon 05 May 2014 11:16:55 AM UTC, original submission:  

This timer is used to check state of fragments of data which need to be re-assembled.
If a timeout occurs the fragments are freed.

This timer was started with a periodicity of 1 sec.
But if there are no fragments to re-assemble still it was being queued and its expiry handler was executed.
The timeout value for each fragment is 3 sec.


Optimization:
1. Start the timer only when first fragment is added to re-assembly queue.
2. If no elements are present in the re-assembly queue do not queue timer.

Benefits:
1. The timer will execute only when there is a fragment in the queue.
2. This stops wakeup of the processor after every 1 sec


Note:
LWIP has 6 such timers which can be optimized.
viz.
IGMP, DNS, DHCP Fine , DHCP coarse, ARP, IPV6 re-assembly

If this IP Re-assembly patch is accepted and made a part of LWIP main stream release I will send out other patches which optimize other timers.

Very Important : Dependency

https://savannah.nongnu.org/bugs/?41686

The above bug is open and it needs to be fixed to avoid crash on fragment re-assembly.




Nirav Desai <niravisneo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by erk (Posted a comment)
  • -email is unavailable- added by niravisneo (Submitted the item)
  • -email is unavailable- added by niravisneo (First timer optimization)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-04-02 erk Open/ClosedOpen Closed
        Discussion LockNone Locked
    2014-05-05 erk StatusNone Invalid
    2014-05-05 niravisneo Attached File- Added 0001-IP-Reassembly-Timer-Optimization.patch, #31310
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code