lwIP - A Lightweight TCP/IP stack - Patches: patch #8446, LWIP IP Re-assembly timer...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8446: LWIP IP Re-assembly timer optimization
| Submitter: | Nirav Desai <niravisneo> | ||
| Submitted: | Mon 05 May 2014 11:53:13 AM UTC | ||
| Category: | IPv4 | Priority: | 6 |
| Status: | Wont Do | Privacy: | Public |
| Assigned to: | None | Open/Closed: | Closed |
| Planned Release: | None | ||
|
Mon 19 May 2014 08:16:10 PM UTC, comment #1: |
Simon Goldschmidt <goldsimon> |
|
Mon 05 May 2014 11:53:13 AM UTC, original submission:
This timer is used to check state of fragments of data which need to be
|
Nirav Desai <niravisneo> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
| Date | Changed by | Updated Field | Previous Value | => | Replaced by |
|---|---|---|---|---|---|
| 2015-02-14 | goldsimon | Status | None | Wont Do | |
| Open/Closed | Open | Closed | |||
| 2014-05-05 | niravisneo | Attached File | - | Added IP-Reassembly-Timer-Optimization.patch, #31311 | |
| Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.12.
Corresponding source code

Your patch is tempting, but it breaks dependencies: as it is now, lwIP core files should not depend on the timer implementation. In other words, everyone is free to implement a different timer implementation as long as the timers are called as needed.
You can see a way to implement what you want in tcp.c/timer.c: TCP calls tcp_timer_needed() when a timer is needed and timer.c then starts the timer if it is not alreay running. This way, developers are free to implement a more efficient way of timer handling in their port and have the TCP timer only running when needed.
Would you mind rewriting your patch to fit this?