patchAVR Downloader/UploaDEr - Patches: patch #8463, typo in rev 1305

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8463: typo in rev 1305

Submitted by:  Georg von Zengen <oni>
Submitted on:  Sun 18 May 2014 09:58:53 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: Joerg Wunsch <joerg_wunsch>Open/Closed: Open

Fri 11 Jul 2014 04:51:33 PM UTC, comment #3:

I'll simply rollback to vfprintf(stderr, ...) for now.

The file avrftdi.c needs some more rework, because it implements its own logging system, which prevents the removing of "verbose"
from the system.

Axel Wachtler <awachtler>
Project Member
Wed 09 Jul 2014 07:25:40 AM UTC, comment #2:

This was not only a typo, at this place there was a vprintf before so it should not replaced by avrdude_message which behaves like printf.

I get an segmentation fault when use for example 'avrdude -cavrftdi -pm8' without a connected programmer, as avrftdi_open fails and it tries to output the error message using this function.

Rene Liebscher <rliebscher>
Project Member
Sun 18 May 2014 11:33:00 AM UTC, comment #1:

Patch is applied rev 1306, thanks for reporting.

Axel Wachtler <awachtler>
Project Member
Sun 18 May 2014 09:58:53 AM UTC, original submission:

Hi,

in rev 1305 there is a typo which prevents avrdude from compiling.
It is in avrftdi.c.
Please check before commiting!

I appended a patch, please apply it.

regards
Georg

Georg von Zengen <oni>

 

Attached Files
file #31398:  typo.patch added by oni (601B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rliebscher (Posted a comment)
  • -unavailable- added by awachtler (Posted a comment)
  • -unavailable- added by oni (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 09 Jul 2014 07:25:40 AM UTCrliebscherStatusDone=>None
      Open/ClosedClosed=>Open
    Sun 18 May 2014 11:42:16 AM UTCawachtlerOpen/ClosedOpen=>Closed
    Sun 18 May 2014 11:33:00 AM UTCawachtlerStatusNone=>Done
      Assigned toNone=>joerg_wunsch
    Sun 18 May 2014 09:58:53 AM UTConiAttached File-=>Added typo.patch, #31398

    Back to the top


    Powered by Savane 3.1-cleanup1