patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8465, Added assertion to check result of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8465: Added assertion to check result of the sys_thread_new() function

Submitter:  Martin Velek <allew>
Submitted:  Mon 19 May 2014 09:14:58 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Wed 11 Feb 2015 08:13:59 PM UTC, comment #2: 

Won't do: there's no need to require everyone implementing the sys_thread_valid() thing: ports just need to ensure sys_thread_new() does not fail! I've added a comment stating this.

Simon Goldschmidt <goldsimon>
Group administrator
Sat 17 Jan 2015 09:50:51 PM UTC, comment #1: 

What exactly is the purpose of this patch? Oh, wait, I see, sys_thread_new returns a value. Well, is it used anywhere? I don't have decent access to the sources right now, but to me, failure to create a thread is always fatal. In that spirit, I tought sys_thread_new should abort hard on failure. Well, seems like we sold make that clearer...

Simon Goldschmidt <goldsimon>
Group administrator
Mon 19 May 2014 09:14:58 PM UTC, original submission:  

This patch adds LWIP_ASSERT() to check return value of the sys_thread_new() function. If defined LWIP_NOASSERT the code remains untouched otherwise the sys_thread_t thread_id variable is added to every function calling sys_thread_new().

There were also added two functions/macros (sys.h) to check if the return value is valid - sys_thread_valid and sys_thread_set_invalid.

This patch assumes the inability of creating slipif_loop_thread, pppInputThread, tcpip_thread threads is a serious error.

Martin Velek <allew>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by allew (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-11 goldsimon StatusNone Wont Do
        Open/ClosedOpen Closed
    2014-05-19 allew Attached File- Added 0001-Added-assertion-to-check-result-of-the-sys_thread_ne.patch, #31403

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code