patchmldonkey, a multi-networks file-sharing client - Patches: patch #8482, BT: fix missing client_ip bind on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8482: BT: fix missing client_ip bind on some ports.

Submitter:  stopdatrue <stopdatrue>
Submitted:  Wed 18 Jun 2014 11:17:21 AM UTC
 
Category:  Bug fixes Priority:  5 - Normal
Status:  None Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

( Jump to the original submission )

Mon 23 Jun 2014 02:27:53 PM UTC, comment #6: 

Yes. Thanks!

ygrek <ygrek>
Project Member
Mon 23 Jun 2014 02:04:27 PM UTC, comment #5: 

Sorry i uploaded the same file.

The final one is #31601

stopdatrue <stopdatrue>
Mon 23 Jun 2014 01:50:23 PM UTC, comment #4: 

Like this?

(file #31600)

stopdatrue <stopdatrue>
Mon 23 Jun 2014 11:43:52 AM UTC, comment #3: 

We don't need to put dht_bind_addr into BT_DHT.t - it is not used anywhere. Also please reverse the order of port and ip parameters (should be ip port). Otherwise looks good to me.

ygrek <ygrek>
Project Member
Mon 23 Jun 2014 11:35:43 AM UTC, comment #2: 

You're right, i don'use the right option here. But the bug remains, the right option not correctly handled is client_bind_addr

# /usr/local/bin/mlnet -client_bind_addr 46.246.55.11 -client_ip 46.246.55.11

# sudo netstat -nlp  | grep mlnet
tcp        0      0 46.246.61.5:6881        0.0.0.0:*               LISTEN      20034/mlnet    
tcp        0      0 46.246.61.5:6882        0.0.0.0:*               LISTEN      20034/mlnet    
tcp        0      0 46.246.61.5:16771       0.0.0.0:*               LISTEN      20034/mlnet    
tcp        0      0 127.0.0.1:4080          0.0.0.0:*               LISTEN      20034/mlnet    
tcp        0      0 46.246.61.5:3504        0.0.0.0:*               LISTEN      20034/mlnet    
udp        0      0 46.246.61.5:16775       0.0.0.0:*                           20034/mlnet    
udp        0      0 0.0.0.0:16911           0.0.0.0:*                           20034/mlnet    
udp        0      0 46.246.61.5:13112       0.0.0.0:*                           20034/mlnet    
udp        0      0 46.246.61.5:3504        0.0.0.0:*                           20034/mlnet

The DHT port is the only port not correctly binded on the given address.

In my case it results in an unwanted behavior, i uses different routing tables depending if the process is binded on a VPN ip address or not, and here packets went outside the vpn.

In attachment you will have the fixed using client_bind_addr instead of client_ip

(file #31599)

stopdatrue <stopdatrue>
Thu 19 Jun 2014 04:48:35 AM UTC, comment #1: 

What problem does this patch solve?
force_client_ip is useful when the user wants to send specific IP in tracker requests etc. It should have nothing to do with binding (though it is used this way in BTTracker, I think that usage is wrong).

ygrek <ygrek>
Project Member
Wed 18 Jun 2014 11:17:21 AM UTC, original submission:  
stopdatrue <stopdatrue>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ygrek (Posted a comment)
  • -email is unavailable- added by stopdatrue (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-06-23 stopdatrue Attached File- Added 0001-DHT-Fix-client_bind_addr-does-not-work-on-DHT-port.patch, #31601
    2014-06-23 stopdatrue Attached File- Added 0001-DHT-fix-missing-client_bind_address-on-DHT-port.patch, #31600
    2014-06-23 stopdatrue Attached File- Added 0001-DHT-fix-missing-client_bind_address-on-DHT-port.patch, #31599
    2014-06-18 stopdatrue Attached File- Added 0001-BT-fix-missing-client_ip-bind-on-some-ports.patch, #31575

    Back to the top


    Powered by Savane 3.9