patchAVR C Runtime Library - Patches: patch #8557, Proposing to remove device...


You are not allowed to post comments on this tracker with your current authentication level.

patch #8557: Proposing to remove device specific xmega macros from sleep.h

Submitted by:  Soundararajan Dhakshinamoorthy <soundararajan>
Submitted on:  Tue 14 Oct 2014 07:22:26 PM UTC  
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Tue 06 Oct 2015 10:05:39 AM UTC, comment #3: 
Senthil Kumar Selvaraj <saaadhu>
Project Member
Wed 15 Oct 2014 07:36:36 PM UTC, comment #2: 

Without reviewing the patch in detail, I basically like the
idea behind it.

Joerg Wunsch <joerg_wunsch>
Project Administrator
Wed 15 Oct 2014 07:29:39 AM UTC, comment #1: 

Alternatively can we move all the SLEEP_MODE macros to the respective device header file ?

This should help us reduce some of the conditions defined in sleep.h. After this, we can generalize the set_sleep_mode() macro based on more simpler conditions (like if HAVE_THIS). But there are specific cases (e.x ATmega161) which we have to live with !

Soundararajan Dhakshinamoorthy <soundararajan>
Tue 14 Oct 2014 07:22:26 PM UTC, original submission:  


The sleep.h file has a list of conditions using device (xmega in particular) macros, that is used to define the appropriate sleep modes and implement the set_sleep_mode macro.

It seems that ALL the xmega devices have the same set of sleep modes (and corresponding bit positions) and the set_sleep_mode implementation. The attached patch (remove_xmega_specifics.patch) removes the individual device macros and adds the _AVR_XMEGA_ macro instead.

Note : Attached ChangeLog to preserve formatting.

Requesting to review the change and approve/comment.


Soundararajan Dhakshinamoorthy <soundararajan>


Attached Files
file #32286:  remove_xmega_specifics_all_headers.patch added by soundararajan (23KiB - text/x-patch - An updated patch with all respective changes in all xmega header files.)
file #32275:  ChangeLog added by soundararajan (268B - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by saaadhu (Posted a comment)
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by soundararajan (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-10-06 saaadhu StatusNone => Done
        Open/ClosedOpen => Closed
    2014-10-17 soundararajan Attached File- => Added remove_xmega_specifics_all_headers.patch, #32286
    2014-10-14 soundararajan Attached File- => Added remove_xmega_specifics.patch, #32274
        Attached File- => Added ChangeLog, #32275

    Back to the top

    Powered by Savane 3.5