patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8570, ppp/ipcp.c: use uint32_t instead...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8570: ppp/ipcp.c: use uint32_t instead of u_int32_t

Submitter:  chrysn <chrysn>
Submitted:  Tue 11 Nov 2014 03:09:07 PM UTC
   
 
Category:  PPP Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  gradator Open/Closed:  Closed
Planned Release:  None

Tue 11 Nov 2014 03:54:15 PM UTC, comment #1: 

Indeed, changed to lwIP internal type u32_t.

Thank you :)

Sylvain Rochet <gradator>
Group Member
Tue 11 Nov 2014 03:09:07 PM UTC, original submission:  


> the style u_int32_t is not used anywhere else in the project, and is not
> supported by the c standard (as opposed to uint32_t, which should come
> from stdint.h). it was introduced in 25e398a.


if ipcp.c is tightly coupled with a pppd upstream, it might be a better idea to typedef u_int32_t at the beginning of the file, but otherwise, this seems to be the clean solution.

chrysn <chrysn>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by chrysn (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-11-11 gradator StatusNone Done
        Assigned toNone gradator
        Open/ClosedOpen Closed
    2014-11-11 chrysn Attached File- Added 0001-ppp-ipcp.c-use-uint32_t-instead-of-u_int32_t.patch, #32420

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code