patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8572, Do not silence ERR_RTE for tcp...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8572: Do not silence ERR_RTE for tcp write

Submitter:  Tomasz Moń <desowin>
Submitted:  Mon 17 Nov 2014 06:00:52 PM UTC
   
 
Category:  sockets/netconn Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Tue 17 Feb 2015 07:04:14 AM UTC, comment #5: 

Done. A netif driver can call tcp_txnow() (from tcpip_thread!) to try to send
again if TX buffers are available again.

The netconn code has been fixed, too, like suggested in this patch.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 16 Feb 2015 09:03:43 PM UTC, comment #4: 

Still not correct plus this is a duplicate to bug #37614 ("Errors from ip_output (ipX_output) are not processing")

Simon Goldschmidt <goldsimon>
Group administrator
Mon 19 Jan 2015 08:20:30 PM UTC, comment #3: 

The v3 patch is still not correct: when tcp_output_segment fails, 'seg' must be put back on the unsent list.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 19 Jan 2015 05:03:31 PM UTC, comment #2: 

ATTENTION: This patch is buggy in that it takes 'seg' off from the unsent list and returns (if tcp_output_segment fails). The segment is then lost (not on any list) and thus never retransmitted.

Simon Goldschmidt <goldsimon>
Group administrator
Sat 17 Jan 2015 09:39:41 PM UTC, comment #1: 

Wille the idee of returning ERR_RTE to the caller seems like a good one, returning all errors from ipX_output could lead to other problems. TCP currently does not do that on purpose, so this patch would change this behaviour. The results of this change would have to be checked first.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 17 Nov 2014 06:00:52 PM UTC, original submission:  

This makes lwip_send return error if no route is available for example due to all interfaces being down (for example: after connection was established someone disconnected network cable).

Tomasz Moń <desowin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #32870:  0001-Do-not-silence-ERR_RTE-for-tcp-write-v4.patch added by desowin (4KiB - text/x-patch - Return segment to unsent list on ERR_RTE)
file #32867:  0001-Do-not-silence-ERR_RTE-for-tcp-write-v3.patch added by desowin (4KiB - text/x-patch - If tcp_output_segment fails with error other than ERR_RTE do not pass that value.)
file #32457:  0001-Do-not-silence-ERR_RTE-for-tcp-write-v2.patch added by desowin (4KiB - text/x-patch - Second version of the patch with slightly improved logic)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by desowin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-17 goldsimon StatusNone Done
    2015-02-16 goldsimon StatusNeed Info None
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2015-01-19 desowin Attached File- Added 0001-Do-not-silence-ERR_RTE-for-tcp-write-v4.patch, #32870
    2015-01-19 desowin Attached File- Added 0001-Do-not-silence-ERR_RTE-for-tcp-write-v3.patch, #32867
    2015-01-17 goldsimon StatusNone Need Info
    2014-11-18 desowin Attached File- Added 0001-Do-not-silence-ERR_RTE-for-tcp-write-v2.patch, #32457
    2014-11-17 desowin Attached File- Added 0001-Do-not-silence-ERR_RTE-for-tcp-write.patch, #32453

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code