patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8618, netif, removed ip_addr,netmask,gw...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8618: netif, removed ip_addr,netmask,gw useless initialization in netif_add()

Submitter:  Sylvain Rochet <gradator>
Submitted:  Wed 11 Mar 2015 08:40:40 PM UTC
   
 
Category:  IPv4 Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Tue 24 Mar 2015 07:13:33 PM UTC, comment #1: 

netif->ip_addr is required to be initialized for the ip_addr_cmp() check in netif_set_ipaddr(), and snmp_delete_iprteidx_tree() is called when setting the netmask, so it should better be initialized to something, too.

I'd therefore rather not remove the zero initialization. On contrary, maybe it would be better to memset(0) the whole struct netif...

Simon Goldschmidt <goldsimon>
Group administrator
Wed 11 Mar 2015 08:40:40 PM UTC, original submission:  

ip_addr,netmask,gw are going to be initialized using netif_set_addr() at the end of netif_add) we don't need to initialize them to zero.

Sylvain Rochet <gradator>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by gradator (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-24 goldsimon StatusNone Wont Do
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2015-03-11 gradator Attached File- Added 0001-netif-removed-ip_addr-netmask-gw-useless-initializat.patch, #33315

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code