patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8678, Remove warnings in unit tests

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8678: Remove warnings in unit tests

Submitter:  Erik Ekman <yarrick>
Submitted:  Thu 28 May 2015 01:24:12 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Wed 05 Aug 2015 08:00:24 PM UTC, comment #2: 

Looks good.

The const warning is because it is a pointer to a pointer, otherwise it would be ok. There seems to be some special case that the const is only applied to one of the pointers.

Erik Ekman <yarrick>
Group Member
Wed 05 Aug 2015 07:17:17 PM UTC, comment #1: 

Thanks for the patches. I always love to fix warnings :-)

However, I have comments and/or changes to a few:
- lwip-0005-test_etharp-Fix-warnings-about-incompatible-pointer-.patch: I don't think I get the problem. You can cast a non-const pointer to a const pointer, can't you? Only the opposite direction should make problems.

- lwip-0003-test_tcp_oos-Fix-warning-from-unsigned-signed-compar.patch: size_t doesn't help: some compilers warn because the #defined constants used below are signed, not unsigned. GCC has a lot of good warnings, but there are still other compilers warning about different things :-)

- lwip-0002-test_tcp_oos-Remove-unused-method-tcp_oos_pbuf_count.patch: tcp_oos_pbuf_count() is not always unused.

I'm using MSVC (for the unit tests at least) and unfortunately, it doesn't warn about any of the things you've fixed.

However, I've committed things in a different way so this should hopefully be fixed for you, too.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 28 May 2015 01:24:12 PM UTC, original submission:  

This is a set of patches to fix warnings seen when compiling the unit tests.

With the patches I get no warnings:

$ make clean; make check
Running suite(s): UDP
 TCP
 TCP_OOS
 MEM
 PBUF
 ETHARP
 DHCP
100%: Checks: 40, Failures: 0, Errors: 0


After lwip-0006 contrib-0001 is needed for the tests to compile.

Erik Ekman <yarrick>
Group Member

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by yarrick (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-08-05 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2015-05-28 yarrick Attached File- Added lwip-0005-test_etharp-Fix-warnings-about-incompatible-pointer-.patch, #34110
        Attached File- Added lwip-0006-unit-tests-Fix-warning-about-unused-create_suite.patch, #34111
        Attached File- Added contrib-0001-unit-tests-Fix-warning-about-unused-create_suite.patch, #34112
        Attached File- Added contrib-0002-unit-tests-Add-test-binary-to-git-ignore.patch, #34113
    2015-05-28 yarrick Attached File- Added lwip-0001-test_tcp_oos-Remove-last_dropped-variable-never-read.patch, #34106
        Attached File- Added lwip-0002-test_tcp_oos-Remove-unused-method-tcp_oos_pbuf_count.patch, #34107
        Attached File- Added lwip-0003-test_tcp_oos-Fix-warning-from-unsigned-signed-compar.patch, #34108
        Attached File- Added lwip-0004-test_etharp-Fix-warning-about-braces.patch, #34109

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code