patchGNU nano - Patches: patch #9117, Fix inconsistently named...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9117: Fix inconsistently named xfce4-terminal in winio.c comments

Submitter:  David Lawrence Ramsey <dolorous>
Submitted:  Tue 13 Sep 2016 03:41:03 PM UTC
   
 
Priority:  5 - Normal Status:  Wont Do
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  None

Thu 20 Oct 2016 05:41:12 PM UTC, comment #3: 

Yes, they are both based on the VTE library, so they probably accept the same Escape sequences, but I'm not sure they interpret all the single-integer keycodes in the same way.

Benno Schulenberg <bens>
Group administrator
Thu 20 Oct 2016 03:52:00 PM UTC, comment #2: 

Okay.  (If I recall correctly, both Gnome-Terminal and XFCE's Terminal are based on the vte library anyway, so they should accept the same sequences.)  New patch attached which does that.

(file #38773)

David Lawrence Ramsey <dolorous>
Group Member
Wed 19 Oct 2016 03:53:28 PM UTC, comment #1: 

(Hrm... I had my email address mistyped and didn't get a notification... :( )

I always thought that "Terminal" referred to Gnome Terminal.  But if it's the Xfce one, then it's easier to change to the references to "Xfce4-terminal" to simply "Terminal".

Benno Schulenberg <bens>
Group administrator
Tue 13 Sep 2016 03:41:03 PM UTC, original submission:  

The attached patch, against nano git 4de0a50, fixes a documentation problem in the comments of winio.c where the terminal included with xfce4 is referred to as Terminal in most places, but Xfce4-terminal in some places.  Since the original references of Terminal are to the Terminal of Xfce4, this names it consistently.

David Lawrence Ramsey <dolorous>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by dolorous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-07 bens StatusNone Wont Do
        Open/ClosedOpen Closed
    2016-10-20 dolorous Attached File- Added nano-55878ef-fixedxfcecomments.patch, #38773
    2016-09-13 dolorous Attached File- Added nano-4de0a50-xfcecomments.patch, #38501

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code