patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9139, Invalid format string in dhcp.c

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9139: Invalid format string in dhcp.c

Submitter:  Thomas Mueller <tmu>
Submitted:  Mon 10 Oct 2016 07:39:20 AM UTC
   
 
Category:  DHCP Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Mon 10 Oct 2016 07:57:39 AM UTC, comment #1: 

Thanks for the fix!

Dirk Ziegelmeier <dziegel>
Group administrator
Mon 10 Oct 2016 07:39:20 AM UTC, original submission:  

Some error messages passed in calls to LWIP_ERROR() in
src/core/ipv4/dhcp.c attempting to print a percent sign
contain invalid conversion specifiers. When compiling
both LWIP_DEBUG and LWIP_NOASSERT defined, a compiler
validating format strings emits warnings/errors accordingly:


./lwip-dist/src/core/ipv4/dhcp.c: In function 'dhcp_parse_reply':
./lwip-dist/src/core/ipv4/dhcp.c:1522:20: error: unknown conversion type character 0x20 in format [-Werror=format=]
         LWIP_ERROR("len % 4 == 0", len % 4 == 0, return ERR_VAL;);


The attached patch fixes this.

Thomas Mueller <tmu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #38691:  dhcp-format.diff added by tmu (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by tmu (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-10-10 dziegel StatusNone Done
        Open/ClosedOpen Closed
    2016-10-10 tmu Attached File- Added dhcp-format.diff, #38691

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code