patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9155, Check external FD_SETSIZE has...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9155: Check external FD_SETSIZE has enough space for number of sockets

Submitter:  Joel Cunningham <jcunningham>
Submitted:  Mon 31 Oct 2016 09:04:45 PM UTC
   
 
Category:  sockets/netconn Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  jcunningham Open/Closed:  Closed
Planned Release:  None

Thu 03 Nov 2016 02:02:35 PM UTC, comment #2: 

Patch committed in d4384cfac41c83e67179013b9d59f6ecb84bf03a

Joel Cunningham <jcunningham>
Group Member
Thu 03 Nov 2016 09:50:59 AM UTC, comment #1: 

Looks OK there, I think it's not worth adding a test in init.c for it...

Simon Goldschmidt <goldsimon>
Group administrator
Mon 31 Oct 2016 09:04:45 PM UTC, original submission:  

I've ran into a case where MEMP_NUM_NETCONN was configured to be larger than FD_SETSIZE provided by the system's toolchain.  This configuration mis-match went undetected

This patch adds a compile time check in sockets.h to ensure an external FD_SETISZE is large enough to handle the configured sockets in sockets.c

I wanted to get feedback if this was the right location for the compile time check versus putting it in init.c before committing

Thanks

Joel Cunningham <jcunningham>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-11-03 jcunningham StatusNone Done
        Assigned toNone jcunningham
        Open/ClosedOpen Closed
    2016-10-31 jcunningham Attached File- Added 0001-Sockets-check-external-FD_SETSIZE-against-number-of-.patch, #38850

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code