patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9217, IPv6 patches: reassembly, length...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9217: IPv6 patches: reassembly, length check improvements

Submitter:  David van Moolenbroek <dcvmoole>
Submitted:  Mon 09 Jan 2017 09:53:35 PM UTC
   
 
Category:  IPv6 Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Wed 11 Jan 2017 01:07:05 PM UTC, comment #1: 

Thanks for your fixes!

Dirk Ziegelmeier <dziegel>
Group administrator
Mon 09 Jan 2017 09:53:35 PM UTC, original submission:  

My attempt to receive a 65535-byte IPv6 packet ended up triggering the new overflow check from patch #9209, and my attempt to fix the underlying cause brought up even more issues..

0001-IPv6-fragment-reassembly-fixes: This patch 1) changes the IPv6 fragmentation code to support reassembly of packets with "unfragmentable" extension headers [*]; 2) stops private data structures (garbage) from being included in ICMPv6 reassembly-timed-out messages; and, 3) implements reassembly correctly even for very large packets. I feel obliged to add that this patch is somewhat under-tested as I have no effective way of testing some of it, but I contend that it is enough of a structural improvement that it is worth merging either way. Also, it does resolve my original problem.. :) If necessary I can work on splitting it into multiple patches. All feedback welcome etc

0002-ip6-improve-length-checks-for-extension-headers: This patch fixes a few "potential read beyond buffer end" cases.

[*] as far as I can tell, this was supported originally (as per RFC requirements) but was lost as part of the IPV6_FRAG_COPYHEADER work, which structurally assumes that the header before the fragment header is the ipv6 header itself.

David van Moolenbroek <dcvmoole>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by dcvmoole (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-11 dziegel StatusNone Done
        Open/ClosedOpen Closed
    2017-01-09 dcvmoole Attached File- Added 0001-IPv6-fragment-reassembly-fixes.patch, #39416
        Attached File- Added 0002-ip6-improve-length-checks-for-extension-headers.patch, #39417

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code