lwIP - A Lightweight TCP/IP stack - Patches: patch #9221, Simplify allocation/deallocation...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9221: Simplify allocation/deallocation of msg
Submitter: | Freddie Chopin <freddie_chopin> | ||
Submitted: | Wed 11 Jan 2017 10:33:22 PM UTC | ||
Category: | sockets/netconn | Priority: | 5 - Normal |
Status: | Invalid | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Planned Release: | None |
Thu 12 Jan 2017 03:31:44 PM UTC, comment #1: |
Dirk Ziegelmeier <dziegel> |
Wed 11 Jan 2017 10:33:22 PM UTC, original submission:
Allocate msg with API_MSG_VAR_ALLOC(msg) just before it is used, so that multiple deallocations with API_MSG_VAR_FREE(msg) in case of error can be simply removed.
|
Freddie Chopin <freddie_chopin> |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-01-12 | dziegel | Status | None | Invalid | |
Open/Closed | Open | Closed | |||
2017-01-11 | freddie_chopin | Attached File | - | Added patches.tar.xz, #39443 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Your patch breaks the code in case of empty pools. e.g. an accept/recv message is lost in case of API message memory errors.
See my fix for bug #47512: MPU_COMPATIBLE may fail on empty pool
in 30e6f908ee98f3af6714880c65672ee08858df66
and 21354af67456edc9bfab0368af662f6d68822a66