GNU nano - Patches: patch #9270, fix another inefficiency in...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9270: fix another inefficiency in display_string(), with very long lines
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Fri 24 Feb 2017 09:04:17 PM UTC | ||
Priority: | 3 - Low | Status: | Done |
Privacy: | Public | Assigned to: | dolorous |
Open/Closed: | Closed | Release: | None |
Tue 28 Feb 2017 04:21:53 PM UTC, comment #3: |
Benno Schulenberg <bens> |
Sat 25 Feb 2017 04:25:46 PM UTC, comment #2: Oops. Attached a second version fixing this. |
David Lawrence Ramsey <dolorous> |
Sat 25 Feb 2017 10:11:14 AM UTC, comment #1: Ehm... The idea sounds good, but the implementation...
|
Benno Schulenberg <bens> |
Fri 24 Feb 2017 09:04:17 PM UTC, original submission:
In current git, display_string() starts scanning text at column start_col/index start_index, and uses start_col to count the number of columns' worth of characters it gets. However, it goes all the way to the end of the text when doing so, and then uses null_at() to cut the text off after span columns. Going through all of the text is unnecessary, and eats up a lot of extra processing time if the line is far longer than that.
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-04-02 | bens | Open/Closed | Open | Closed | |
2017-02-28 | bens | Priority | 5 - Normal | 3 - Low | |
Status | None | Done | |||
Assigned to | None | dolorous | |||
2017-02-25 | dolorous | Attached File | - | Added 0001-tweaks-stop-processing-text-once-we-overshoot-span-c.patch, #39830 | |
2017-02-24 | dolorous | Attached File | - | Added 0001-tweaks-stop-processing-text-once-we-overshoot-span-c.patch, #39824 |
Powered by Savane 3.13-758e.
Corresponding source code
Applied to git, 0404474e, with a rename plus a significant modification: the column beyond the last one is computed from the original start_col, not from the possibly increased start_col due to double-width characters straddling the screen's edge.
Thanks.