patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9299, SNTP round-trip delay compensation

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9299: SNTP round-trip delay compensation

Submitter:  Daniel Elstner <danielk>
Submitted:  Fri 24 Mar 2017 12:05:07 PM UTC
   
 
Category:  apps Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Wed 03 May 2017 12:00:44 AM UTC, comment #5: 

Minor follow-up: Avoid a compiler warning about an unused static function if LWIP_DEBUG is not defined.

(file #40565)

Daniel Elstner <danielk>
Mon 27 Mar 2017 10:23:53 AM UTC, comment #4: 

Pushed, thanks for the patch.

Simon Goldschmidt <goldsimon>
Group administrator
Sun 26 Mar 2017 10:17:59 PM UTC, comment #3: 

Some more changes: The 64-bit types are now defined as optional feature in arch.h, and I split the work into 4 patches now.

(file #40155)

Daniel Elstner <danielk>
Fri 24 Mar 2017 01:55:23 PM UTC, comment #2: 

That's fine. You're right, I modified the timestamp handling quite a bit to prepare for the new feature. I've now split the changes into two patches, attached in mbox format.

(file #40114)

Daniel Elstner <danielk>
Fri 24 Mar 2017 01:11:42 PM UTC, comment #1: 

The idea looks good, but in my personal view, the patch has too many changes not directly related to what you say.
In other words, as it's not a "no change if disabled" patch, I would want to review it before pushing.
(Of course reviewing could be sped up by providing a step-by-step patchset if you have one...)

Simon Goldschmidt <goldsimon>
Group administrator
Fri 24 Mar 2017 12:05:07 PM UTC, original submission:  

The attached patch implements the calculation for SNTP round-trip delay compensation as defined in RFC 4330. It would be great if this could go into lwIP proper. I also refactored the NTP timestamp handling a bit to keep things manageable.

One little catch: The compensation requires compiler support for 64-bit arithmetic. Since round-trip compensation is disabled by default, I hope this is acceptable. However, 64 bit integers are not covered by arch.h, so I defined these types locally for now. But it might be better to put the typedefs into arch.h as optional feature.

Daniel Elstner <danielk>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #40565:  0001-SNTP-Avoid-warning-if-debugging-is-disabled.patch added by danielk (1020B - text/x-patch - Minor warning fix)
file #40155:  sntp-comp-roundtrip-2.mbox added by danielk (21KiB - application/mbox - SNTP round-trip compensation patchset, take 3)
file #40114:  sntp-comp-roundtrip.mbox added by danielk (17KiB - application/mbox - SNTP round-trip compensation patchset, take 2)
file #40113:  0001-SNTP-Implement-round-trip-delay-compensation.patch added by danielk (14KiB - text/x-patch - SNTP round-trip compensation, take 1)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by danielk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-05-03 danielk Attached File- Added 0001-SNTP-Avoid-warning-if-debugging-is-disabled.patch, #40565
    2017-03-27 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2017-03-26 danielk Attached File- Added sntp-comp-roundtrip-2.mbox, #40155
    2017-03-24 danielk Attached File- Added sntp-comp-roundtrip.mbox, #40114
    2017-03-24 danielk Attached File- Added 0001-SNTP-Implement-round-trip-delay-compensation.patch, #40113

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code