lwIP - A Lightweight TCP/IP stack - Patches: patch #9339, mdns: support for deleting...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9339: mdns: support for deleting responder services and searching services on network
Submitter: | David GIRAULT <dgirault> | ||
Submitted: | Wed 10 May 2017 08:26:00 AM UTC | ||
Category: | apps | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Mon 07 Aug 2017 10:16:17 AM UTC, comment #15: |
Dirk Ziegelmeier <dziegel> |
Fri 04 Aug 2017 07:37:28 AM UTC, comment #14: Since this one was partially merged (the responder service part) and I've made some change in the searching part, I'll make a new patch which will address only the mdns search part.
|
David GIRAULT <dgirault> |
Wed 31 May 2017 11:42:19 AM UTC, comment #13: Hi Simon,
|
David GIRAULT <dgirault> |
Wed 17 May 2017 06:55:00 PM UTC, comment #12:
|
Simon Goldschmidt <goldsimon> |
Fri 12 May 2017 02:05:10 PM UTC, comment #11: Nice to have patch #1 already pushed.
|
David GIRAULT <dgirault> |
Fri 12 May 2017 01:21:33 PM UTC, comment #10: OK, to the 2nd patch:
|
Simon Goldschmidt <goldsimon> |
Fri 12 May 2017 11:23:05 AM UTC, comment #9: Then let's do it like in etharp.c and return s8_t where >= 0 means index and < 0 is an err_t.
|
Simon Goldschmidt <goldsimon> |
Fri 12 May 2017 08:50:44 AM UTC, comment #8: I done it this way as I didn't want to change the API of the `mdns_resp_add_service()`.
|
David GIRAULT <dgirault> |
Wed 10 May 2017 07:52:26 PM UTC, comment #7: That would still mix 2 types. Returning an int. In any case, the return value must match the parameter passed to the remove function! |
Simon Goldschmidt <goldsimon> |
Wed 10 May 2017 12:36:25 PM UTC, comment #6: Ok. I think I understood. What about just changing `slot` to be an `s8_t` ? |
David GIRAULT <dgirault> |
Wed 10 May 2017 12:04:18 PM UTC, comment #5:
|
Simon Goldschmidt <goldsimon> |
Wed 10 May 2017 11:47:52 AM UTC, comment #4: Patches files rebase on latest master (ie. 'ae210967'). |
David GIRAULT <dgirault> |
Wed 10 May 2017 11:46:53 AM UTC, comment #3: Sorry, I don't understand your comment #2. I can't return an int for function declared to return an int?
|
David GIRAULT <dgirault> |
Wed 10 May 2017 10:34:15 AM UTC, comment #2: From trying to read patch 1 manually: you can't return 'int slot' when the function's return type is 'int'! |
Simon Goldschmidt <goldsimon> |
Wed 10 May 2017 10:31:39 AM UTC, comment #1: "Could not parse revision. libgit2 returned: revspec '6e8faea' not found" |
Simon Goldschmidt <goldsimon> |
Wed 10 May 2017 08:26:00 AM UTC, original submission:
This patch will add to mdns apps:
|
David GIRAULT <dgirault> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-08-07 | dziegel | Status | None | Done | |
Open/Closed | Open | Closed | |||
2017-05-31 | dgirault | Attached File | - | Added 0001-mdns-added-support-for-searching-services.patch, #40822 | |
2017-05-10 | dgirault | Attached File | - | Added 0001-mdns-added-support-for-removing-service-in-mdns-resp.patch, #40646 | |
Attached File | - | Added 0002-mdns-added-support-for-searching-services.patch, #40647 | |||
2017-05-10 | dgirault | Attached File | - | Added 0001-mdns-added-support-for-removing-service-in-mdns-resp.patch, #40643 | |
Attached File | - | Added 0002-mdns-added-support-for-searching-services.patch, #40644 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Closed as requested by David. (-> new patch for mdns search part)