patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9425, tcp: remove extra seg == NULL...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9425: tcp: remove extra seg == NULL checks

Submitted by:  Joel Cunningham <jcunningham>
Submitted on:  Thu 03 Aug 2017 03:43:24 PM UTC  
 
Category:  TCP Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Joel Cunningham <jcunningham> Open/Closed:  Closed
Planned Release:  None

Thu 03 Aug 2017 07:28:28 PM UTC, comment #2: 

Patch submitted in 6fa5d02435ba8893efacd5acd9736b0752fe964e, thanks for the review :)

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.
Thu 03 Aug 2017 07:19:05 PM UTC, comment #1: 

Looks fine. I stumbled accross this seg==NULL check before and it seems I have lost track of it :-)

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 03 Aug 2017 03:43:24 PM UTC, original submission:  

Found some duplicate if (seg == NULL) checks in tcp_output that can be combined.  Please see attached patch.

I wanted to double check that there wasn't a reason why LWIP_DEBUGF calls with TCP_OUTPUT_DEBUG and TCP_CWND_DEBUG were guarded by #if/#endif.  I couldn't see any reason why since LWIP_DEBUGF is a no-op when LWIP_DEBUG is not defined

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-03 jcunningham StatusNeed Info => Done
        Open/ClosedOpen => Closed
    2017-08-03 jcunningham Attached File- => Added 0001-tcp-remove-extra-seg-NULL-checks.patch, #41402

    Back to the top


    Powered by Savane 3.5