patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9451, Fixes a bug in clearing unneeded...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9451: Fixes a bug in clearing unneeded TCP SACKs

Submitted by:  Jakub Schmidtke <jschmidtke>
Submitted on:  Fri 08 Sep 2017 08:04:42 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Simon Goldschmidt <goldsimon> Open/Closed:  Closed
Planned Release:  None

( Jump to the original submission)

Sat 09 Sep 2017 07:51:56 PM UTC, comment #8: 

Pushed, thanks for the patch!

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sat 09 Sep 2017 07:07:05 PM UTC, comment #7: 

You're right about the '7'. However, 747a0181 does not show anything for me either, so how can it be used for applying a patch? I don't get it.
Anyway, this specific patch should be easy to apply anyway...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 08 Sep 2017 09:24:01 PM UTC, comment #6: 

I mean 'git log 747a0181' and it works (despite not showing anything). 'git log 47a0181' fails.

Jakub Schmidtke <jschmidtke>
Fri 08 Sep 2017 09:22:28 PM UTC, comment #5: 

Something is wrong. There is no 47a0181, but those patches are referencing 747a0181. The first one is missing "7" at the beginning. I just cloned a fresh copy, and generated a patch against that, and it was exactly the same. I'm not sure what 747a0181 is, but I can do 'git log' in that fresh copy, and it works.

Jakub Schmidtke <jschmidtke>
Fri 08 Sep 2017 08:21:39 PM UTC, comment #4: 

OK, after cleaning my tree, the "manual" diff way works. Nevertheless, the patches seem to reference a git commit that doesn't exist in our repo. And that means the next change to the file in question could make it stop applying.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 08 Sep 2017 08:15:21 PM UTC, comment #3: 

I was able to apply the "updated" patch on top of 8c040093577da2a65cfa195349e25b8990f216af using 'git apply' with no issues

Joel Cunningham <jcunningham>
Project Member
Fri 08 Sep 2017 08:10:40 PM UTC, comment #2: 

"revspec '47a0181' not found" for both files...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 08 Sep 2017 08:08:15 PM UTC, comment #1: 

Updated with a fixed patch (wrong e-mail in the commit).

(file #41766)

Jakub Schmidtke <jschmidtke>
Fri 08 Sep 2017 08:04:42 PM UTC, original submission:  

I have noticed, that sometimes ACK packets include SACKs for data that is before the ACK in the same packet (meaning it was SACKing data already delivered in-order).
Turns out the SACK ranges were cleared before final modifications in ooseq queue after new packet delivery.
This patch fixes that.

Jakub Schmidtke <jschmidtke>

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jcunningham (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jschmidtke (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-09 goldsimon StatusNone => Done
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed
    2017-09-08 jschmidtke Attached File- => Added 0001-Fixed-removing-unneeded-TCP-SACKs_updated.patch, #41766
    2017-09-08 jschmidtke Attached File- => Added 0001-Fixed-removing-unneeded-TCP-SACKs.patch, #41765

    Back to the top


    Powered by Savane 3.5