patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9462, Build unit tests on MacOS

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9462: Build unit tests on MacOS

Submitter:  Joel Cunningham <jcunningham>
Submitted:  Thu 12 Oct 2017 11:08:46 PM UTC
   
 
Category:  Platform ports Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  jcunningham Open/Closed:  Closed
Planned Release:  None

Jump to the original submission

Fri 10 Nov 2017 04:42:41 AM UTC, comment #9: 

Thanks for the review, committed in 5463806e9ff7a10f117a8887d30457423ba8d20c

Closing this for now since unit tests are building and executing for me with no local changes :)

Joel Cunningham <jcunningham>
Group Member
Tue 31 Oct 2017 06:47:28 PM UTC, comment #8: 

Looks good, OK to apply for me!

Dirk Ziegelmeier <dziegel>
Group administrator
Sun 29 Oct 2017 09:36:32 PM UTC, comment #7: 

I'm not sure I completely understand what 'additional var passed to CC' means, but I've removed the duplication of assigning UNAME_S and it is now only done in common.mk, which I can see is included in check/Makefile before the first use of UNAME_S.  See new patch :)

I don't have any preference for use of CMake/configure, I was just wondering if that's the system which normally handles setting up the LDFLAGS and such depending on what libraries are present on the system during run-time detection


(file #42294)

Joel Cunningham <jcunningham>
Group Member
Mon 23 Oct 2017 08:01:55 PM UTC, comment #6: 

The code duplication in /ports/unix/check/Makefile around line 58 should be refactored into an additional var passed to CC.
The rest looks OK.
I think this way it is better readable for a broader audience then if we would use autoconf or cmake.

Simon Goldschmidt <goldsimon>
Group administrator
Sun 22 Oct 2017 07:53:35 PM UTC, comment #5: 

I think your patch is OK.

Please, no "configure" mess in lwIP :-)

I'd prefer cmake...

Dirk Ziegelmeier <dziegel>
Group administrator
Sat 21 Oct 2017 06:16:52 PM UTC, comment #4: 

I did some more hacking on the makefiles and I have a better patch that adds MacOS support without changing the existing unix behavior.

Free feel to point out any best practices or common ways to handle these changes. My Make experience is just what I've learned on a couple Saturday afternoons ;)

I think handling these platform differences is typically done by configure but we haven't taken that leap yet!

(file #42213)

Joel Cunningham <jcunningham>
Group Member
Fri 13 Oct 2017 01:00:05 PM UTC, comment #3: 

1 & 2 have been pushed in de531131c54103543dcd95aeedfc99a8e95220a0 and 0f96523fa4b4593bf89c3f73da57fef93eee390c

> What's your plan for 3? Leave this task open?


Yes, the patch can be used by others for now, but I'll work on it more and discuss how to handle the differences

Joel Cunningham <jcunningham>
Group Member
Fri 13 Oct 2017 09:50:32 AM UTC, comment #2: 

1 & 2 look good. What's your plan for 3? Leave this task open?

Simon Goldschmidt <goldsimon>
Group administrator
Thu 12 Oct 2017 11:10:51 PM UTC, comment #1: 

Also, the lwip patch to fix warnings has also been verified with win32 port and unix port under Linux

Joel Cunningham <jcunningham>
Group Member
Thu 12 Oct 2017 11:08:46 PM UTC, original submission:  

I've got the LwIP unit tests building on MacOS 10.12.6 with clang 8.1.0

I'm using 'make CC=clang check' to build

I've attached the following patches:

1. Fix warnings in lwip repo seen with clang 8.1.0 (ready for submission)
2. Build unix port in MacOS in contrib repo (ready for submission)
3. Hack Make files to build on MacOS (this is a work in progress, other can use for now if they want to build on MacOS)

This is a hobby task, so might be some time before I can finish up the Make file integration (ideas welcome, I don't have a ton of experiences with writing Make files)

Joel Cunningham <jcunningham>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-10 jcunningham StatusIn Progress Done
        Open/ClosedOpen Closed
    2017-10-29 jcunningham Attached File- Added 0001-Add-make-support-for-unit-tests-on-MacOS-w-clang-v2.patch, #42294
    2017-10-21 jcunningham Attached File- Added 0001-Add-make-support-for-unit-tests-on-MacOS-w-clang.patch, #42213
    2017-10-12 jcunningham Attached File- Added 0001-lwip-Fix-compiler-warnings-seen-with-clang-8.1.0-on-MacOS.patch, #42133
        Attached File- Added 0002-contrib-Hack-make-files-to-work-with-MacOS.patch, #42134
        Attached File- Added 0001-contrib-Build-unix-port-on-MacOS-clang.patch, #42135

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code