lwIP - A Lightweight TCP/IP stack - Patches: patch #9462, Build unit tests on MacOS
You are not allowed to post comments on this tracker with your current authentication level.
patch #9462: Build unit tests on MacOS
Submitter: | Joel Cunningham <jcunningham> | ||
Submitted: | Thu 12 Oct 2017 11:08:46 PM UTC | ||
Category: | Platform ports | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | jcunningham | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Fri 10 Nov 2017 04:42:41 AM UTC, comment #9: |
Joel Cunningham <jcunningham> |
Tue 31 Oct 2017 06:47:28 PM UTC, comment #8: Looks good, OK to apply for me! |
Dirk Ziegelmeier <dziegel> |
Sun 29 Oct 2017 09:36:32 PM UTC, comment #7: I'm not sure I completely understand what 'additional var passed to CC' means, but I've removed the duplication of assigning UNAME_S and it is now only done in common.mk, which I can see is included in check/Makefile before the first use of UNAME_S. See new patch :)
|
Joel Cunningham <jcunningham> |
Mon 23 Oct 2017 08:01:55 PM UTC, comment #6: The code duplication in /ports/unix/check/Makefile around line 58 should be refactored into an additional var passed to CC.
|
Simon Goldschmidt <goldsimon> |
Sun 22 Oct 2017 07:53:35 PM UTC, comment #5: I think your patch is OK.
|
Dirk Ziegelmeier <dziegel> |
Sat 21 Oct 2017 06:16:52 PM UTC, comment #4: I did some more hacking on the makefiles and I have a better patch that adds MacOS support without changing the existing unix behavior.
|
Joel Cunningham <jcunningham> |
Fri 13 Oct 2017 01:00:05 PM UTC, comment #3: 1 & 2 have been pushed in de531131c54103543dcd95aeedfc99a8e95220a0 and 0f96523fa4b4593bf89c3f73da57fef93eee390c
|
Joel Cunningham <jcunningham> |
Fri 13 Oct 2017 09:50:32 AM UTC, comment #2: 1 & 2 look good. What's your plan for 3? Leave this task open? |
Simon Goldschmidt <goldsimon> |
Thu 12 Oct 2017 11:10:51 PM UTC, comment #1: Also, the lwip patch to fix warnings has also been verified with win32 port and unix port under Linux |
Joel Cunningham <jcunningham> |
Thu 12 Oct 2017 11:08:46 PM UTC, original submission:
I've got the LwIP unit tests building on MacOS 10.12.6 with clang 8.1.0
|
Joel Cunningham <jcunningham> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-11-10 | jcunningham | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2017-10-29 | jcunningham | Attached File | - | Added 0001-Add-make-support-for-unit-tests-on-MacOS-w-clang-v2.patch, #42294 | |
2017-10-21 | jcunningham | Attached File | - | Added 0001-Add-make-support-for-unit-tests-on-MacOS-w-clang.patch, #42213 | |
2017-10-12 | jcunningham | Attached File | - | Added 0001-lwip-Fix-compiler-warnings-seen-with-clang-8.1.0-on-MacOS.patch, #42133 | |
Attached File | - | Added 0002-contrib-Hack-make-files-to-work-with-MacOS.patch, #42134 | |||
Attached File | - | Added 0001-contrib-Build-unix-port-on-MacOS-clang.patch, #42135 |
Powered by Savane 3.13-758e.
Corresponding source code
Thanks for the review, committed in 5463806e9ff7a10f117a8887d30457423ba8d20c
Closing this for now since unit tests are building and executing for me with no local changes :)