patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9516, sntp: use const for servername

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9516: sntp: use const for servername

Submitter:  Joel Cunningham <jcunningham>
Submitted:  Wed 13 Dec 2017 05:38:02 PM UTC
   
 
Category:  apps Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  jcunningham Open/Closed:  Closed
Planned Release:  None

Wed 13 Dec 2017 08:16:40 PM UTC, comment #2: 

Thanks for the quick review, committed in 920ee2d07ee50d24e8d1fe01c207587f26d07a53

Joel Cunningham <jcunningham>
Group Member
Wed 13 Dec 2017 07:56:32 PM UTC, comment #1: 

Looks good, please commit!

Dirk Ziegelmeier <dziegel>
Group administrator
Wed 13 Dec 2017 05:38:02 PM UTC, original submission:  

This adds const to the sntp servername get/set API and internal storage

SNTP's usage of this name is read only and SNTP only passes it to dns_gethostbyname()

This was found by compiling with GCC -Wwrite-strings which makes the literal
SNTP_SERVER_ADDRESS a const string. This then produced warnings with sntp_init()'s
call to sntp_setservername()

Joel Cunningham <jcunningham>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #42638:  0001-sntp-use-const-for-servername.patch added by jcunningham (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-12-13 jcunningham StatusNone Done
        Assigned toNone jcunningham
        Open/ClosedOpen Closed
    2017-12-13 jcunningham Attached File- Added 0001-sntp-use-const-for-servername.patch, #42638

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code