lwIP - A Lightweight TCP/IP stack - Patches: patch #9534, freertos: misc fixes, core locking...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9534: freertos: misc fixes, core locking check support.
Submitter: | Douglas <ourairquality> | ||
Submitted: | Thu 04 Jan 2018 01:52:21 PM UTC | ||
Category: | Platform ports | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Sat 06 Jan 2018 01:25:12 PM UTC, comment #4: |
Simon Goldschmidt <goldsimon> |
Sat 06 Jan 2018 06:13:32 AM UTC, comment #3:
|
Douglas <ourairquality> |
Fri 05 Jan 2018 07:55:07 PM UTC, comment #2: Thanks, I've merged a lot of your patches.
|
Simon Goldschmidt <goldsimon> |
Thu 04 Jan 2018 02:01:27 PM UTC, comment #1: Observation: it might be better to make the unit of the stack size argument to sys_thread_new be stack words rather than bytes for the freertos port. FreeRTOS stack sizes are generally in units of stack words so it might be more consistent and less confusing to keep to that for lwip too. I note that TCPIP_THREAD_STACKSIZE is defined as a platform dependent value, so perhaps using a unit of stack words is ok. |
Douglas <ourairquality> |
Thu 04 Jan 2018 01:52:21 PM UTC, original submission:
Make a quick pass comparing the contrib freertos example to the esp-open-rtos support for FreeRTOS and here are some suggestions to consider. |
Douglas <ourairquality> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-01-06 | goldsimon | Open/Closed | Open | Closed | |
2018-01-05 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
2018-01-04 | ourairquality | Attached File | - | Added 0001-freertos-misc-fixes-core-locking-check-support.patch, #42824 |
Powered by Savane 3.13-3230.
Corresponding source code
Ok, so since we have a preprocessor check that INCLUDE_vTaskDelay is enabled, we should not need the loop. Maybe there's a return value to check for in the futuer. I'd rather go the safe way and check for "OK" instead of retrying for all possible erors.
It helps to keep the code cleaner and keep compile times low (less headers included). You might be able to save some bytes in the generated code though when doing it your way. You'd have to check that...