lwIP - A Lightweight TCP/IP stack - Patches: patch #9792, mDNS: mdns_search_service...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9792: mDNS: mdns_search_service mdns_search_stop: define the request id as unsigned.
Submitter: | Douglas <ourairquality> | ||
Submitted: | Fri 12 Apr 2019 01:22:20 AM UTC | ||
Category: | apps | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Tue 30 Apr 2019 12:54:31 PM UTC, comment #10: |
Dirk Ziegelmeier <dziegel> |
Tue 30 Apr 2019 12:53:03 PM UTC, comment #9: Argh, sorry!!! I missed your change to mdns_search_service - everything is fine!! |
Dirk Ziegelmeier <dziegel> |
Tue 30 Apr 2019 12:51:34 PM UTC, comment #8: Sorry I don't understand why you claim that mdns_search_service returns a s8_t as the patch is as follows:
|
Douglas <ourairquality> |
Tue 30 Apr 2019 12:41:18 PM UTC, comment #7: One function (mdns_search_service) returns an s8_t (via pointer) and the other function (mdns_search_stop) needs this value as u8_t - so you have to cast in application code. My point is: Change BOTH functions to u8_t or leave both as they are now.
|
Dirk Ziegelmeier <dziegel> |
Tue 30 Apr 2019 12:27:49 PM UTC, comment #6: The patch changes it to accept a pointer to a u8_t. There are no uses of mdns_search_service() in the lwip source code to patch, so it should give no compilation errors?
|
Douglas <ourairquality> |
Tue 30 Apr 2019 12:11:06 PM UTC, comment #5: Yes, but it's a pointer to s8_t instead of u8_t.
|
Dirk Ziegelmeier <dziegel> |
Tue 30 Apr 2019 12:08:34 PM UTC, comment #4: Thank you for taking a look. Could you please double check, as mdns_search_service() appears to return the request ID via a pointer argument, not as the result value. It is the request ID that is passed back to mdns_search_stop(), and the suggestion is to make that an u8_t. The return value from mdns_search_service() can remain an err_t. |
Douglas <ourairquality> |
Tue 30 Apr 2019 10:45:52 AM UTC, comment #3: The change looks inconsistent to me - it would be OK if mdns_search_service() is changed to return u8_t, too.
|
Dirk Ziegelmeier <dziegel> |
Tue 23 Apr 2019 10:48:02 AM UTC, comment #2: The request ID is an unsigned integer so declaring it as such seems most appropriate (to me anyway). The search service functions are relatively new additions, and also an option, so it might be best to change this now - if that is the consensus.
|
Douglas <ourairquality> |
Tue 23 Apr 2019 09:01:17 AM UTC, comment #1: Well, this one will change API and require change in application too to avoid compilation error:
|
David GIRAULT <dgirault> |
Fri 12 Apr 2019 01:22:20 AM UTC, original submission:
|
Douglas <ourairquality> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-04-30 | dziegel | Status | None | Done | |
Open/Closed | Open | Closed | |||
2019-04-12 | ourairquality | Attached File | - | Added 0001-mdns-mdns_search_service-mdns_search_stop-define-the.patch, #46756 |
Powered by Savane 3.13-4448.
Corresponding source code
Applied, thanks!