patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9815, ALTCP_TLS_MBEDTLS: include...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9815: ALTCP_TLS_MBEDTLS: include mbedtls/net_sockets.h instead of deprecated mbedtls/net.h

Submitter:  Giuseppe Modugno <giusloq>
Submitted:  Tue 11 Jun 2019 09:55:31 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Fri 26 Jul 2019 06:30:15 PM UTC, comment #3: 


> If you look at mbedtls/net.h you will see that it actually includes mbedtls/net_sockets.h


Right. Even in an older version I have around here...

Applied, thanks for the hint!

Simon Goldschmidt <goldsimon>
Group administrator
Wed 12 Jun 2019 07:52:41 AM UTC, comment #2: 

If you look at mbedtls/net.h you will see that it actually includes mbedtls/net_sockets.h. The only difference is that including net.h seems deprecated.

Sincerely I don't know why they made net.h deprecated, maybe its name conflicts in some building platforms.

Yes, lwip doesn't use sockets. However lwip actually uses some macros defined in net.h/net_sockets.h, for example MBEDTLS_ERR_NET_CONN_RESET.

Giuseppe Modugno <giusloq>
Tue 11 Jun 2019 07:15:26 PM UTC, comment #1: 

But including net_sockets.h seems wrong: we're not using sockets?

Simon Goldschmidt <goldsimon>
Group administrator
Tue 11 Jun 2019 09:55:31 AM UTC, original submission:  

As mbedTLS git master source code says, mbedtls/net.h is deprecated. It is included in alpc_tls_mbedtls.c.

In my project I replaced net.h with net_sockets.h without any problem. However I don't sumbit a patch, because I don't know if there could be other problems.

Giuseppe Modugno <giusloq>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by giusloq (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-07-26 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code