lwIP - A Lightweight TCP/IP stack - Patches: patch #9883, Fix typos using codespell
You are not allowed to post comments on this tracker with your current authentication level.
patch #9883: Fix typos using codespell
Submitter: | Jonathan D <jona> | ||
Submitted: | Mon 06 Jan 2020 11:21:59 PM UTC | ||
Category: | None | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Sat 15 Feb 2020 08:56:49 PM UTC, comment #6: |
Simon Goldschmidt <goldsimon> |
Wed 12 Feb 2020 11:22:55 PM UTC, comment #5: You are right, codespell can automatically fix the errors. However, the automatic fixing of errors should be executed with the greatest care. I would recommend a human check somewhere in the process. |
Jonathan D <jona> |
Mon 10 Feb 2020 09:02:36 PM UTC, comment #4: Yes. I just tested check.sh. I was under the impression that codespell could automatically fix the errors it finds, am I wrong there? |
Simon Goldschmidt <goldsimon> |
Sat 08 Feb 2020 04:01:29 PM UTC, comment #3: Hello,
|
Jonathan D <jona> |
Mon 13 Jan 2020 10:41:21 PM UTC, comment #2: Here is another review of the idea.
|
Jonathan D <jona> |
Thu 09 Jan 2020 08:59:58 PM UTC, comment #1: Nice patch. However:
|
Simon Goldschmidt <goldsimon> |
Mon 06 Jan 2020 11:21:59 PM UTC, original submission:
The next step to avoid typo can be to provide a script like for RIOT: https://github.com/RIOT-OS/RIOT/blob/master/dist/tools/codespell/check.sh |
Jonathan D <jona> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-02-15 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2020-01-13 | jona | Attached File | - | Added 0001-Add-codespell-wrappers-check.sh-changed_files.sh.patch, #48225 | |
Attached File | - | Added 0001-Fix-typos-using-codespell.patch, #48226 | |||
2020-01-06 | jona | Attached File | - | Added 0001-Fix-typos-using-codespell.patch, #48174 |
Powered by Savane 3.13-3230.
Corresponding source code
Applied, thanks for the patches.
I've added the possibility to call the script with "-w" to write back changed files to disk so the changes can be viewed with "git diff" and applied -> found more fixes that way.