patchmldonkey, a multi-networks file-sharing client - Patches: patch #4657, Improve endianness checking in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4657: Improve endianness checking in tiger.c, md5_c.c and CryptoPP.h, print endianness in buildinfo, removed sha1_old code

Submitter:  spiralvoice <spiralvoice>
Submitted:  Mon 28 Nov 2005 04:02:54 PM UTC
   
 
Category:  Bug fixes Priority:  9 - Immediate
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 30 Nov 2005 11:46:51 PM UTC, comment #5: 

Applied 2005/01/12

spiralvoice <spiralvoice>
Group administrator
Tue 29 Nov 2005 06:11:13 PM UTC, comment #4: 

change Makefile.in, it`s necessary on mingw to put the path to ocaml inside quotes, otherwise caml/config.h cannot be included and compiling fails

Schlumpf <schlumpf_>
Group Member
Tue 29 Nov 2005 02:35:01 PM UTC, comment #3: 

tiger tree startup error message went away for users with AMD64 (reported on IRC by sekretatz) and mipsel CPUs (reported by turkish on the German forum)

spiralvoice <spiralvoice>
Group administrator
Tue 29 Nov 2005 02:48:20 AM UTC, comment #2: 

Updated patch to use

#include <caml/config.h>
#if defined(ARCH_BIG_ENDIAN)

Ocaml checks endianness of machines during ./configure so there
is no need for MLDonkey to check endianness itself.

Also improved code for glibc_version()

sha1_old* code was removed, sha1_new* renamed to sha1*
sha1_old was kept for platforms where endianness is unknown, but
with the new method based on Ocaml values all platforms have
known endianness.

Patch tested on Linux x86, FreeBSD 6.0 x86, both little endian,
and Solaris 9/Sparc big endian.

Please test on as many archs as possible.

spiralvoice <spiralvoice>
Group administrator
Mon 28 Nov 2005 04:28:04 PM UTC, comment #1: 

Updated patch to display machine endianness in buildinfo

spiralvoice <spiralvoice>
Group administrator
Mon 28 Nov 2005 04:02:54 PM UTC, original submission:  

./configure checks endianness, until now this was only used in
sha1 C code.
tiger.c and md5_c.c had their own (incomplete) ways of checking endianness, see bug #14664 for problems on 64bit little
endian machines which IMHO are assumed big endian.

This patch promises to solve this bug, the endianness check code
from sha1_new_c.c has been moved to endian_check.h so it can be
re-used by sha1_new_c.c, tiger.c, md5_c.c and CryptoPP.h.

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #4345:  endianess_mingw.patch added by schlumpf_ (498B - application/octet-stream)
file #4344:  4657.patch added by spiralvoice (59KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 12 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-30 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-11-30 spiralvoice SummaryImprove endianness checking in tiger.c, m5_c.c and CryptoPP.h, print endianness in buildinfo, removed sha1_old code Improve endianness checking in tiger.c, md5_c.c and CryptoPP.h, print endianness in buildinfo, removed sha1_old code
2005-11-29 schlumpf_ Attached File- Added endianess_mingw.patch, #5528
2005-11-29 spiralvoice Attached File#5524 Removed
2005-11-29 spiralvoice Attached File- Added 4657.patch, #5526
2005-11-29 spiralvoice SummaryImprove endianness checking in tiger.c, m5_c.c and CryptoPP.h, print endianness in buildinfo Improve endianness checking in tiger.c, m5_c.c and CryptoPP.h, print endianness in buildinfo, removed sha1_old code
2005-11-28 spiralvoice SummaryImprove endianness checking in tiger.c, m5_c.c and CryptoPP.h Improve endianness checking in tiger.c, m5_c.c and CryptoPP.h, print endianness in buildinfo
2005-11-28 spiralvoice StatusNone Ready For Test
2005-11-28 spiralvoice Attached File#5523 Removed
2005-11-28 spiralvoice Attached File- Added 4657.patch, #5524
2005-11-28 spiralvoice Attached File- Added endian.patch, #5523

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code