patchmldonkey, a multi-networks file-sharing client - Patches: patch #4725, Check if ulimit is sufficient for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4725: Check if ulimit is sufficient for MLDonkey, auto-adjust max_opened_connections

Submitter:  spiralvoice <spiralvoice>
Submitted:  Sun 18 Dec 2005 07:16:59 PM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Wed 28 Dec 2005 09:37:56 PM UTC, comment #6: 

Applied 2005/12/28

spiralvoice <spiralvoice>
Group administrator
Wed 28 Dec 2005 07:08:59 PM UTC, comment #5: 

Updated patch for current CVS

spiralvoice <spiralvoice>
Group administrator
Sat 24 Dec 2005 02:20:31 AM UTC, comment #4: 

Updated patch

  • removed commonFile stuff and use List.length !!files
  • moved ED2K-max_indirect_connections to downloads.ini because its used by commonSources
  • max_indirect_connections is now a %-value of max_opened_connections
  • minimum ulimit for open files is now 150, MLDonkey will refuse to start if ulimit is lower
  • minimum max_opened_connections is now 75
  • reduced max_concurrent_downloads from 60 to 50

  minimum ulimit -n 150 is used like this:
  - 75 max_opened_connections
  - 50 downloading files
  - 5 upload slots
  - 20 fd as reserve for ini files

Is "+ 20" enough in total_files functions? Or are there alternatives for calculation?

spiralvoice <spiralvoice>
Group administrator
Tue 20 Dec 2005 12:48:11 AM UTC, comment #3: 

Files are never removed while the core is running AFAIK.  It is the same number.

z <zet>
Group Member
Tue 20 Dec 2005 12:40:08 AM UTC, comment #2: 

file_counter is not the same as file_total_num ().
file_counter is a on-going numbering of all files, new files
increment file_counter by one, but this value is not reduced
if files are removed.

spiralvoice <spiralvoice>
Group administrator
Sun 18 Dec 2005 07:50:35 PM UTC, comment #1: 

file_total_num () is a duplicate of file_counter isn't it?

The rest of the code is hard to read (and doesn't seem to be indented like the rest of mldonkey code), but I think much of it belongs in option hooks (on max_opened_connections option or similar).

z <zet>
Group Member
Sun 18 Dec 2005 07:16:59 PM UTC, original submission:  


spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9379:  4725.patch added by spiralvoice (16KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 10 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-12-28 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-12-28 spiralvoice Attached File#5655 Removed
2005-12-28 spiralvoice Attached File#5640 Removed
2005-12-28 spiralvoice Attached File- Added 4725.patch, #5675
2005-12-28 spiralvoice StatusNone Ready For Test
2005-12-24 spiralvoice Attached File- Added 4725.patch, #5655
2005-12-18 spiralvoice Attached File- Added 4725.patch, #5640
2005-12-18 spiralvoice Attached File#5638 Removed
2005-12-18 spiralvoice Attached File- Added check_fd.patch, #5638

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code