patchToos - Patches: patch #694, GNU Autotools support

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #694: GNU Autotools support

Submitter:  Stephen Compall <S11001001>
Submitted:  Thu 21 Nov 2002 11:07:02 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  rudy Open/Closed:  Open

Wed 18 Dec 2002 10:51:09 PM UTC, comment #2: 

Your error on configure.ac[26] is a problem with an old version not stripping away the M4 quotes properly.  But it did enable me to find an unrelated bug in autoconf 2.57 :-)

http://csserver.evansville.edu/~sc87/toos-autotools-2.tar.gz

This is the new set.  Please note that I have explicitly required autoconf 2.57 and automake 1.7.2; though some earlier versions will most likely work, I did not test these.  You can tweak the setting in configure.ac.

I can't test the LaTeX build properly, as I don't have the Babel Dutch files; it seems to do ok though.  I wrote some notes about it in doc/Makefile.am.

Finally, I abused the new (as of am 1.7) non-recursive make features, so your src directory rules are in the top-level.  However, this seems to put .o files in the top-level instead of src (though I only got 1 .o file, thanks to compile errors in Persoon.h).  I think this might be a bug in Automake (the .o location, not the Persoon.h stuff ! ;-), and they said non-recursive make was new and probably has problems.  If this bothers you please ask whether this is a bug or not, or move the src rules back into their own src/Makefile.am.

Finally, autoscan recommended that you check for struct tm, and you can abuse the macro I inserted as follows:

 - Macro: AC_STRUCT_TM
     If `time.h' does not define `struct tm', define
     `TM_IN_SYS_TIME', which means that including
     `sys/time.h' had better define `struct tm'.

And finally, to take advantage of the configure defines, you should insert this at the top of every built source file (not header, as this will lead to multiple includes), before all other includes and source:

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif

Stephen Compall <S11001001>
Fri 13 Dec 2002 10:24:34 PM UTC, comment #1: 

Hi,

I unpacked the tarball in my toos dir en did the bootstrap:
bash-2.05a$ ./bootstrap
autoheader2.50: `config.h.in' is created
configure.ac: 26: `automake requires `AM_CONFIG_HEADER', not `AC_CONFIG_HEADER'
automake: configure.ac: installing `./install-sh'
automake: configure.ac: installing `./mkinstalldirs'
automake: configure.ac: installing `./missing'
automake: Makefile.am: installing `./INSTALL'
configure.ac: 26: required file `./[config.h].in' not found

Also I wasn't able to run ./configure (the file wasn't even made)...

Could you fix these errors (and in the meanwhile update it so the new src files are added :))

Thanks

Rudy

Rudy Gevaert <rudy>
Group administrator
Thu 21 Nov 2002 11:07:02 PM UTC, original submission:  

BTW, you need Automake 1.7 or later and Autoconf 2.53 or later for this to work.

Stephen Compall <S11001001>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #4823:  patch_item_694.patch added by S11001001 (1KiB - text/plain - patch item 694)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follows 1 latest change.

Date Changed by Updated Field Previous Value => Replaced by
2002-12-13 rudy Assigned toNone None

Back to the top

Powered by Savane 3.13-3230.
Corresponding source code