patchlwIP - A Lightweight TCP/IP stack - Patches: patch #10085, format LWIP codes

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #10085: format LWIP codes

Submitter:  Meco Man <mysterywolf>
Submitted:  Sun 27 Jun 2021 09:20:29 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Thu 28 Sep 2023 08:37:08 PM UTC, comment #3: 

I think someone has already done this partly, but I'm also not a fan of such patches...

Simon Goldschmidt <goldsimon>
Group administrator
Mon 28 Jun 2021 01:01:56 PM UTC, comment #2: 

OK, you may close it if you think this PR is not proper. I don't know how to close this PR.

Meco Man <mysterywolf>
Sun 27 Jun 2021 11:37:06 AM UTC, comment #1: 

Please don't do that. lwIP is not a beauty pageant. New code should follow coding rules, old code can stay the way it is, especially the PPP code which mostly came from pppd.

Added to that, reviewing such a big change set is boresome, and it makes the output of diffs before the cleanup and after unusable.

Sylvain Rochet <gradator>
Group Member
Sun 27 Jun 2021 09:20:29 AM UTC, original submission:  

use space to replace tab and remove meaningless space in the end of each line.

Meco Man <mysterywolf>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by gradator (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-09-28 goldsimon StatusNone Wont Do
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2021-12-29 mysterywolf Carbon-CopyRemoved 262077 -
    2021-06-27 mysterywolf Attached File- Added 0001-use-space-to-replace-tab-and-remove-meaningless-spac.patch, #51602

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code